Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for consistent Settings Sidebar terminology #16438

Merged
merged 5 commits into from
Jul 8, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jul 5, 2019

Description

Follow up on #16138 updating documentation in glossary and block registration to use the Settings Sidebar terminology instead of Inspector. This is consistent with the Designer Reference.

Types of changes

Documentation changes.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Jul 5, 2019
@mkaz mkaz requested a review from sarahmonster July 8, 2019 16:40
Copy link
Member

@sarahmonster sarahmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor pedantic feedback, but overall this looks like a good improvement. 👍

docs/designers-developers/glossary.md Outdated Show resolved Hide resolved
@mkaz mkaz force-pushed the docs/16138-settings-term branch from 529aed4 to 7aa5420 Compare July 8, 2019 22:06
mkaz and others added 5 commits July 8, 2019 15:17
- Updates Inspector definition stating it is deprecated and directs user
to Settings Sidebar

- Expand Settings Sidebar definition
@mkaz mkaz force-pushed the docs/16138-settings-term branch from 7aa5420 to 62dbbac Compare July 8, 2019 22:18
@mkaz mkaz merged commit 5471bad into master Jul 8, 2019
@mkaz mkaz deleted the docs/16138-settings-term branch July 8, 2019 22:38
@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants