[Mobile]Fix video upload #16331
Merged
[Mobile]Fix video upload #16331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
pinarol
commented
Jun 27, 2019
| @@ -64,7 +64,7 @@ class VideoEdit extends React.Component { | |||
|
|
|||
| componentDidMount() { | |||
| const { attributes } = this.props; | |||
| if ( attributes.id && attributes.url && ! isURL( attributes.src ) ) { | |||
There was a problem hiding this comment.
I remember like attributes.url was not becoming undefined when we close/open a post during the upload. but now it is, so it is now useless and preventing the block from calling mediaUploadSync. maybe sth changed in the infrastructure that is causing this but I think removing this altogether should be fine.
pinarol
added
the
Mobile App - i.e. Android or iOS
pinarol
requested review from
aduth,
ajitbohra,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
etoledom
added a commit
that referenced
this pull request
Jul 8, 2019
Trying to triger Travis CI with the same changes and see if it still fails JS Unit Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#1173
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1182
How has this been tested?
Tested with gutenberg-mobile PR
Screenshots
Types of changes
Checklist: