ESLint Plugin: react-no-unsafe-timeout: Consider variable assignment as valid #16292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
aduth
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
nerrad,
ntwb and
talldan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15622
This pull request seeks to resolve an issue with the custom
react-no-unsafe-timeoutrule, notably affecting usage in combination withuseEffect.Implementation Notes:
The original implementation included tolerances for
setTimeoutwhere the result was assumed to be used for future cancelling (in the unmount). However, it only accounted for assignment to an instance property (this.handle = setTimeout( ... )), and not use as a variable.Testing Instructions:
Ensure there are no lint errors:
Verify unit tests pass: