-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Video block on Android after Android X migration #16215
Merged
daniloercoli
merged 2 commits into
master
from
rnmobile/enable-video-block-after-android-x-migration
Jun 21, 2019
Merged
Re-enable Video block on Android after Android X migration #16215
daniloercoli
merged 2 commits into
master
from
rnmobile/enable-video-block-after-android-x-migration
Jun 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniloercoli
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Jun 18, 2019
mkevins
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on WordPress-Android. Looks good, LGTM!
marecar3
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
youknowriad
deleted the
rnmobile/enable-video-block-after-android-x-migration
branch
June 24, 2019 09:59
hypest
pushed a commit
that referenced
this pull request
Jun 28, 2019
marecar3
pushed a commit
that referenced
this pull request
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the Video block on Android.
Companion Mobile Gutenberg PR: wordpress-mobile/gutenberg-mobile#1150
Video block was disabled right before 1.7 version of gb-mobile, since there were issues with the Android implementation. #16149