Fix: Image block does not retain the dimensions when opening the media library #16125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
gziolo,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
jorgefilipecosta
changed the title
youknowriad
approved these changes
Jul 4, 2019
jorgefilipecosta
force-pushed
the
fix/image-block-does-not-retain-the-dimensions-when-opening-the-media-library
branch
from
655285d
to
23c6e76
Compare
jorgefilipecosta
force-pushed
the
fix/image-block-does-not-retain-the-dimensions-when-opening-the-media-library
branch
from
23c6e76
to
675fb0e
Compare
jorgefilipecosta
deleted the
fix/image-block-does-not-retain-the-dimensions-when-opening-the-media-library
branch
|
I added a unit test before the merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9737
Currently, in the image block, if we open the media library and we select the same image the "Image Size" (URL) and the dimensions are reset.
It seems after the upload some users may first select the desired size and then open the media library to change the media object itself (and not just the block) and add alt, description, etc. Doing this resets the choose image size. This PR fixes that problem.
How has this been tested?
I upload an image, I changed the dimensions using the resizer. I pressed the change image button, I opened the media library and I changed the caption of the image. I verified the new caption was applied and the dimensions were kept.
I repeated the test but instead of changing dimensions I changed the "Image Size" option of the image to "Full Image".