-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase WordPress minimum to 5.2.0 #15809
Conversation
We discussed this a little bit here #15565 and there seemed to be an agreement to use cc @jeremyfelt @aduth @WordPress/gutenberg-core |
Having usage stats on what wp versions people are using would be helpful here. With that said, I think its a reasonable assumption that most folks using the plugin understand what it is and are more likely to be on the latest WordPress (or wouldn't have to much issue with getting on the latest WordPress). |
Thanks for your feedback. I understand that we should not increase the minimum too early. But it should also be a goal that users update their WordPress version promptly and don't remain on the same version. If users update their plugins, they are also able to update their WordPress Core. Yoast recently released a blog post about this topic, in the future they only support the current and the previous major WP version. This is a feature plugin, so I think we can update the minimum supported version maybe even faster. Gutenberg 5.9 would be June 12th. (More than a month after WordPress 5.2) or we wait for Gutenberg 6.0 after WordCamp Europe? |
A takeaway I like from this is to have a policy about it, so it's known and predictable. It's unclear what benefit there is in waiting? Or in supporting older versions at all? Conversely, there is some benefit in not waiting, as noted by referenced issues of the original comment (removing "baggage"). |
Yes, documenting this process would be great. It's not the first time we have a discussion about this. Let's have it once and make it a no brainer for the future. |
In #18414, I also see a change in the config file for PHPUnit: Line 6 in 1e359a8
I think Travis file doesn't run PHP 5.2 and 5.3 anymore: |
@gziolo Thanks, I added the change to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that in the next plugin release and maybe even consider 5.3 soon.
Description
In WordPress 5.2 the PHP minimum was updated to PHP 5.6.20.
Gutenberg is a feature Plugin for WordPress development. We should set WordPress 5.2 as minimum, so we can remove old PHP compatibility code and tests for old versions.
Related #15796 and #15806