-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TinyMCE per block prototype: Add image with caption block #155
Conversation
85bee96
to
1e0fb5d
Compare
Do you think this ought to be a separate block or an option to the existing base image blocks? Related is how we'll need to support existing content which may include |
I don't have a final answer for now. I decided to go separate for now to show an image without any caption text field which changes the way the keyboard (arrows, enter, backspace) behaves. I can answer with another question. How do we "enable" a caption for a simple image block? In case of a separate block, we could use the "transform" API (same as switching between paragraph and heading for example). but what if it's the same component, should we always show the caption input?
My personal answer to that, is to limit the way the editor stores the post content to one unique way. So maybe the answer to this question is having the grammar parse those different ways of writing the same block into the same structure, but serializing this data would use one way only. |
Per the current mockup, I think this is what to expect, yes (cc @jasmussen).
We'll definitely need to think on this. I agree ideally if we settle on a block syntax, that should be the recommendation for all new posts. If that were the case, we'd certainly need to be able to detect and upgrade the previous syntax to the new variation, if only in the context of the editor itself. The most contentious question might be: If we detect old syntax, should we save it as new syntax if the user updates the post? What impact does this have on plugins that, for example, hook into and modify a |
Thanks for the ping @aduth.
We will likely want captions for lots of blocks. I can easily imagine inserting video with a caption, or even a code block with a caption. Which blocks might need a dedicated caption vs. just a single linebreak with a simple text, that's up for discussion. Maybe best discussed in #16. UI-wise, we could show the caption input field only when the block is selected? I.e. Insert an image and move on, no caption field is shown. Click the image later on, and the caption field "pops out" below. CC: @mtias |
Update React Native to version 0.57
No description provided.