Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen: Remove unneccessary argument from Array#pop #15397

Merged
merged 1 commit into from
May 2, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented May 2, 2019

Previously: #13329 (comment)

This pull request seeks to remove an unnecessary argument from an instance of Array#pop in the docgen package. Array#pop receives no arguments, and it is thus unnecessary.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/pop

Testing Instructions:

Ensure unit tests pass:

npm run test-unit

@aduth aduth added [Type] Code Quality Issues or PRs that relate to code quality [Package] Docgen /packages/docgen labels May 2, 2019
@aduth aduth requested a review from oandregal May 2, 2019 16:02
@aduth aduth requested review from gziolo and mkaz as code owners May 2, 2019 16:02
@aduth aduth merged commit 23043f8 into master May 2, 2019
@aduth aduth deleted the remove/docgen-unnecessary-pop-argument branch May 2, 2019 18:22
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Docgen /packages/docgen [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants