Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Update package-lock.json #14808

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 3, 2019

Previously: https://github.com/WordPress/gutenberg/pull/14664/files#r271885310

This pull request seeks to update package-lock.json file per dependency changes in #14664.

Separately, we should explore why the check-local-changes npm script is not correctly identifying local changes in Travis.

@aduth aduth added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Apr 3, 2019
@aduth aduth requested a review from ellatrix April 3, 2019 19:00
@aduth
Copy link
Member Author

aduth commented Apr 3, 2019

Separately, we should explore why the check-local-changes npm script is not correctly identifying local changes in Travis.

Ah, this is probably why:

- npm ci

npm ci doesn't update package-lock.json

Edit: Hmm, but it is supposed to exit with error status code if package-lock.json is inaccurate (reference).

Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry about that. Would be good to make Travis return an error. :)

@aduth
Copy link
Member Author

aduth commented Apr 3, 2019

Yeah, I'm not really sure what's going on there, even after digging further into how Travis handles errors. Based on how some other projects explicitly incorporate npm ci for the very purpose of validating package-lock.json (google/clasp#118), it seems like it should be fine as-is. I'm wondering if it has something to do with Lerna and our dependencies being defined as local file paths.

@ellatrix
Copy link
Member

ellatrix commented Apr 3, 2019

Hm, but that still wouldn't explain memize? Or do you mean something else?

@aduth aduth merged commit 5cf4e14 into master Apr 3, 2019
@aduth aduth deleted the update/14664-package-lock-json branch April 3, 2019 20:43
@aduth
Copy link
Member Author

aduth commented Apr 3, 2019

Hm, but that still wouldn't explain memize? Or do you mean something else?

It could, since memize is a transitive dependency (it was a dependency of @wordpress/annotations; annotations is a file-path dependency in the root package.json).

"@wordpress/annotations": "file:packages/annotations",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants