Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setRef for post-title in Gutenberg Mobile. #13874

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Implement setRef for post-title in Gutenberg Mobile. #13874

merged 3 commits into from
Feb 15, 2019

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Feb 14, 2019 •
edited
Loading

Description

Implements setRef for post-title so that the native component of it can be focused.

How has this been tested?

This has been tested in: wordpress-mobile/gutenberg-mobile#599

Types of changes

Modified post-title and rich-text native so that they forward setRef to the native componetn.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@diegoreymendez diegoreymendez added [Status] In Progress Tracking issues with work in progress Mobile Web Viewport sizes for mobile and tablet devices labels Feb 14, 2019
@diegoreymendez diegoreymendez self-assigned this Feb 14, 2019
@diegoreymendez diegoreymendez mentioned this pull request Feb 14, 2019
Merged
@diegoreymendez diegoreymendez removed the [Status] In Progress Tracking issues with work in progress label Feb 14, 2019
@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 14, 2019
daniloercoli
daniloercoli approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diegoreymendez diegoreymendez merged commit bb6dfea into master Feb 15, 2019
@diegoreymendez diegoreymendez deleted the try/forward-ref-to-post-title branch February 15, 2019 03:28
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@diegoreymendez @youknowriad
Implement setRef for post-title in Gutenberg Mobile. (#13874)
4a93f5d 
* WIP

* Rolls back the changes to PostTitle.

* Implements setRef for post-title.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@diegoreymendez @youknowriad
Implement setRef for post-title in Gutenberg Mobile. (#13874)
b7416e7 
* WIP

* Rolls back the changes to PostTitle.

* Implements setRef for post-title.
@gziolo gziolo removed the Mobile Web Viewport sizes for mobile and tablet devices label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloercoli daniloercoli daniloercoli approved these changes

Assignees

@diegoreymendez diegoreymendez

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@diegoreymendez @daniloercoli @youknowriad @gziolo