Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign default font and font size styles to the notice component #13817

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Assign default font and font size styles to the notice component #13817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/src/notice/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.components-notice {
font-family: $default-font;
font-size: $default-font-size;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I wonder if we should do an audit and do this consistently across our reusable UI components. For example, I also noticed that the block placeholders and the buttons can be altered by editor styles.

Also what properties should we add: font-family, font-size, maybe also color, background and line-height?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely might be worth an audit. 👍 I'll merge this in for now though.

background-color: $blue-medium-100;
border-left: 4px solid $blue-medium-500;
margin: 5px 15px 2px;
Expand Down