Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Plugin: Restrict tolerances as fixable error #13785

Merged
merged 2 commits into from
Feb 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/annotations/src/store/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { registerStore } from '@wordpress/data';

Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/edit.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* External Dependencies
* External dependencies
*/
import classnames from 'classnames';
import { filter, pick, map, get } from 'lodash';
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/gallery/gallery-image.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/**
* External Dependencies
* External dependencies
*/
import classnames from 'classnames';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { Component, Fragment } from '@wordpress/element';
import { IconButton, Spinner } from '@wordpress/components';
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/latest-comments/index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/**
* WordPress dependencies.
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { G, Path, SVG } from '@wordpress/components';

/**
* Internal dependencies.
* Internal dependencies
*/
import edit from './edit';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/draggable/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { noop } from 'lodash';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { Component } from '@wordpress/element';
import { withSafeTimeout } from '@wordpress/compose';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
/**
* External Dependencies
* External dependencies
*/
import classnames from 'classnames';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { Component } from '@wordpress/element';
import { createHigherOrderComponent } from '@wordpress/compose';

/**
* Internal Dependencies
* Internal dependencies
*/
import KeyboardShortcuts from '../../keyboard-shortcuts';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/modal/header.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies.
* Internal dependencies
*/
import IconButton from '../icon-button';

Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/navigable-container/container.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/**
* External Dependencies
* External dependencies
*/
import { omit, noop, isFunction } from 'lodash';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { Component, forwardRef } from '@wordpress/element';
import { focus } from '@wordpress/dom';
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/navigable-container/menu.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/**
* External Dependencies
* External dependencies
*/
import { includes } from 'lodash';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { forwardRef } from '@wordpress/element';
import { UP, DOWN, LEFT, RIGHT } from '@wordpress/keycodes';
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/navigable-container/tabbable.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { forwardRef } from '@wordpress/element';
import { TAB } from '@wordpress/keycodes';
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/responsive-wrapper/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import classnames from 'classnames';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { cloneElement, Children } from '@wordpress/element';

Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/server-side-render/index.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/**
* External dependencies.
* External dependencies
*/
import { isEqual, debounce } from 'lodash';

/**
* WordPress dependencies.
* WordPress dependencies
*/
import {
Component,
Expand All @@ -15,7 +15,7 @@ import apiFetch from '@wordpress/api-fetch';
import { addQueryArgs } from '@wordpress/url';

/**
* Internal dependencies.
* Internal dependencies
*/
import Placeholder from '../placeholder';
import Spinner from '../spinner';
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/slot-fill/test/slot.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import Fill from '../fill';
import Provider from '../context';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { Component } from '@wordpress/element';

Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-test-utils/src/create-url.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Node dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was probably some reason to use Node keyword but I'm happy to see it merged into External group 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was probably some reason to use Node keyword but I'm happy to see it merged into External group 👍

I suppose the idea is the imports are from the Node.js API, not any explicit dependency. I could see there being some value in it, but it's not something we either codified or use consistently. Same goes for "Browser dependencies".

As part of this overall effort, I'm fine to make adjustments from what we've standardized. But the important thing is forcing ourselves to have these conversations, rather than let inconsistencies grow via the unwritten conventions of a few people.

* External dependencies
*/
import { join } from 'path';
import { URL } from 'url';
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-test-utils/src/is-current-url.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Node dependencies
* External dependencies
*/
import { URL } from 'url';

Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-test-utils/src/visit-admin-page.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Node dependencies
* External dependencies
*/
import { join } from 'path';

Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/adding-inline-tokens.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Node dependencies
* External dependencies
*/
import path from 'path';
import fs from 'fs';
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/manage-reusable-blocks.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Node dependencies
* External dependencies
*/
import path from 'path';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { shallow } from 'enzyme';

/**
* Internal dependencies.
* Internal dependencies
*/
import { FullscreenMode } from '..';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { flow } from 'lodash';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { withSelect, withDispatch } from '@wordpress/data';
import { compose } from '@wordpress/compose';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/**
* External Dependencies
* External dependencies
*/
import { get } from 'lodash';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { withSelect } from '@wordpress/data';
import { IconButton, Toolbar } from '@wordpress/components';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { withDispatch } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/**
* External Dependencies
* External dependencies
*/
import { get } from 'lodash';

/**
* WordPress dependencies.
* WordPress dependencies
*/
import { compose } from '@wordpress/compose';
import { withDispatch, withSelect } from '@wordpress/data';
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-post/src/components/header/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { shallow } from 'enzyme';

/**
* Internal dependencies.
* Internal dependencies
*/
import { PostPublishButtonOrToggle } from '../post-publish-button-or-toggle';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { MenuGroup } from '@wordpress/components';
import { __, _x } from '@wordpress/i18n';
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-post/src/components/sidebar/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { createSlotFill, withFocusReturn } from '@wordpress/components';
import { withSelect } from '@wordpress/data';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { withSelect, withDispatch } from '@wordpress/data';
import { compose } from '@wordpress/compose';

/**
* Internal Dependencies
* Internal dependencies
*/
import PostVisibility from '../post-visibility';
import PostTrash from '../post-trash';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* External Dependencies
* External dependencies
*/
import { get } from 'lodash';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { BlockInspector } from '@wordpress/editor';
import { Fragment } from '@wordpress/element';
import { __ } from '@wordpress/i18n';
/**
* Internal Dependencies
* Internal dependencies
*/
import Sidebar from '../';
import SettingsHeader from '../settings-header';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* External Dependencies
* External dependencies
*/
import { castArray, defaults, pick } from 'lodash';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { MenuItem } from '@wordpress/components';
import { withDispatch } from '@wordpress/data';
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-post/src/store/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { registerStore } from '@wordpress/data';

Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/block-drop-zone/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* External Dependencies
* External dependencies
*/
import classnames from 'classnames';

Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/block-inspector/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { withSelect } from '@wordpress/data';
import { Fragment } from '@wordpress/element';

/**
* Internal Dependencies
* Internal dependencies
*/
import SkipToSelectedBlock from '../skip-to-selected-block';
import BlockIcon from '../block-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/editor/src/components/block-list/block-html.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@

/**
* External Dependencies
* External dependencies
*/
import TextareaAutosize from 'react-autosize-textarea';
import { isEqual } from 'lodash';

/**
* WordPress Dependencies
* WordPress dependencies
*/
import { Component } from '@wordpress/element';
import { compose } from '@wordpress/compose';
Expand Down
4 changes: 2 additions & 2 deletions packages/editor/src/components/block-toolbar/index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/**
* WordPress Dependencies
* WordPress dependencies
*/
import { withSelect } from '@wordpress/data';
import { Fragment } from '@wordpress/element';

/**
* Internal Dependencies
* Internal dependencies
*/
import BlockSwitcher from '../block-switcher';
import MultiBlocksSwitcher from '../block-switcher/multi-blocks-switcher';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from '@wordpress/components';

/**
* Internal Dependencies
* Internal dependencies
*/
import BlockIcon from '../block-icon';

Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/post-permalink/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ClipboardButton, Button, ExternalLink } from '@wordpress/components';
import { safeDecodeURI } from '@wordpress/url';

/**
* Internal Dependencies
* Internal dependencies
*/
import PostPermalinkEditor from './editor.js';
import { getWPAdminURL, cleanForSlug } from '../../utils/url';
Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/post-publish-panel/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { withSelect, withDispatch } from '@wordpress/data';
import { compose } from '@wordpress/compose';

/**
* Internal Dependencies
* Internal dependencies
*/
import PostPublishButton from '../post-publish-button';
import PostPublishPanelPrepublish from './prepublish';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
import { find, get, includes } from 'lodash';

/**
* WordPress dependencies.
* WordPress dependencies
*/
import { __, sprintf } from '@wordpress/i18n';
import { ifCondition, compose } from '@wordpress/compose';
import { withDispatch, withSelect } from '@wordpress/data';
import { Button, PanelBody } from '@wordpress/components';

/**
* Internal dependencies.
* Internal dependencies
*/
import { POST_FORMATS } from '../post-format';

Expand Down
Loading