-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds placeholder coloring support for mobile's rich text component. #13738
Merged
hypest
merged 2 commits into
master
from
try/add-placeholder-support-for-rich-text-mobile
Feb 7, 2019
Merged
Adds placeholder coloring support for mobile's rich text component. #13738
hypest
merged 2 commits into
master
from
try/add-placeholder-support-for-rich-text-mobile
Feb 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and works fine 👍
diegoreymendez
changed the title
Adds placeholder support for mobile's rich text component.
Adds placeholder coloring support for mobile's rich text component.
Feb 7, 2019
Should we add |
gziolo
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Feb 7, 2019
@daniloercoli , you can do that in a separate PR if needed it seems. I will merge this now. |
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
…13738) * Adds placeholder support for mobile's rich text component. * Removes an unnecessary line of code.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
…13738) * Adds placeholder support for mobile's rich text component. * Removes an unnecessary line of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds placeholder support for mobile's rich text component.
How has this been tested?
Through this PR: wordpress-mobile/gutenberg-mobile#560
Types of changes
Just wires a few existing properties.
Checklist: