Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Links Block #13725

Closed

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Feb 7, 2019

Description

This PR adds a new Social Links Block. This addresses a common user requirement to add a list of Social Links (Icons or Icons + Text) to their site.

An existing Issue exists with initial Design exploration.

Whilst this is similar to the Menu Block being discussed at #13690, a dedicated Block for Social Links is required because:

  • Users don't expect to use a Menu Block to build a list of Social Icons.
  • Trying to overcomplicate the Menu Block with the functionality required to achieve Social Links will overburden that Block
  • Creating dedicated Blocks for specific purposes can often provide better UX allowing us to tailor the experience for the specific pattern. Social Links is one of those cases. Going too "meta" with other Blocks to try and do everything will deliver a poorer UX.

Moreover, a quick review of some popular website building tools (eg: Wix, GoDaddy...etc) reveals that they have a dedicated Component for Social Links. Given the popularity of these platforms, this provides more evidence that included a dedicated Block for Social Links addresses a common user need.

How has this been tested?

TBC

Screenshots

TBC

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Initial commit for PR to address

WordPress#1873
@getdave getdave changed the title Adds Block directory placeholder Social Links Block Feb 7, 2019
@getdave getdave closed this Feb 7, 2019
@getdave
Copy link
Contributor Author

getdave commented Feb 7, 2019

Closed as opening a PR as a placeholder is discouraged in this repo. Apologies.

Will open a PR when the work is ready for review.

@gziolo
Copy link
Member

gziolo commented Feb 7, 2019

Closed as opening a PR as a placeholder is discouraged in this repo. Apologies.

Is it? If you have any code to share, I think it's fine to push it to get early feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants