Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to remove usage of post related effects in packages/editor. #13716

Merged
merged 32 commits into from
Feb 28, 2019
Merged

Refactor to remove usage of post related effects in packages/editor. #13716

merged 32 commits into from
Feb 28, 2019

Commits on Feb 28, 2019

  1. add controls for fetch, select, and dispatch

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    7e1d857 View commit details
    Browse the repository at this point in the history

  2. move _all_ constants into the constants file for better organization

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    77a812c View commit details
    Browse the repository at this point in the history

  3. establish file structure, begin refactoring post effects/actions

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    ae3f60b View commit details
    Browse the repository at this point in the history

  4. Implement trashPost action-generator 

    - also rename functions for getting notification dispatch arguments (a little less mouthy)
    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    a673b8e View commit details
    Browse the repository at this point in the history

  5. fix import jsdocs

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    25c74c2 View commit details
    Browse the repository at this point in the history

  6. update controls to use new createRegistryControl interface

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    54fbc38 View commit details
    Browse the repository at this point in the history

  7. add action generator for refreshing the current post

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    455d6a8 View commit details
    Browse the repository at this point in the history

  8. add tests for new code 

    - also removes old code that’s been replaced and fixes up imports
    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    5d246e5 View commit details
    Browse the repository at this point in the history

  9. fix broken tests

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    0008288 View commit details
    Browse the repository at this point in the history

  10. don’t continue with refreshPost if there’s no current post yet

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    de8e6d1 View commit details
    Browse the repository at this point in the history

  11. remove unnecessary bail

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    64216f4 View commit details
    Browse the repository at this point in the history

  12. add changelog entry

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    f80fae4 View commit details
    Browse the repository at this point in the history

  13. fix lint failure for import order

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    97b1ed5 View commit details
    Browse the repository at this point in the history

  14. fix incorrect method used for autosave requests

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    9bce642 View commit details
    Browse the repository at this point in the history

  15. remove another wayward period.

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    36f962d View commit details
    Browse the repository at this point in the history

  16. Add resolveSelect control and implement

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    d69599f View commit details
    Browse the repository at this point in the history

  17. refactor to condense code and update tests.

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    4cba06a View commit details
    Browse the repository at this point in the history

  18. update docs

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    b3beb7f View commit details
    Browse the repository at this point in the history

  19. fix doc blocks

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    651216d View commit details
    Browse the repository at this point in the history

  20. fix jsdocs for param object properties

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    a455781 View commit details
    Browse the repository at this point in the history

  21. simplify import statement 

    - this also initially experimented with just mocking `actions.savePost` for the autosave test but that didn’t work.  Needed to revert to the usage of a generatorActions default export for that.
    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    1a4fc0c View commit details
    Browse the repository at this point in the history

  22. utilize constants from constants file

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    49f5af6 View commit details
    Browse the repository at this point in the history

  23. remove unused constants (now in block-editor)

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    a41039c View commit details
    Browse the repository at this point in the history

  24. simplify import

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    2c14df4 View commit details
    Browse the repository at this point in the history

  25. add doc blocks for control actions

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    f66af80 View commit details
    Browse the repository at this point in the history

  26. update docs

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    5568ac3 View commit details
    Browse the repository at this point in the history

  27. make sure test is importing used constant

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    6d74643 View commit details
    Browse the repository at this point in the history

  28. fix doc block spacing issues

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    ff70f2b View commit details
    Browse the repository at this point in the history

  29. Swith constant name from MODULE_KEY to STORE_KEY

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    1c11a5b View commit details
    Browse the repository at this point in the history

  30. remove use of generatorActions default import ans switch to dispatch … 

    …control for autosave
    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    4cc4015 View commit details
    Browse the repository at this point in the history

  31. doc changes

    @nerrad
    nerrad committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    0ba7d0e View commit details
    Browse the repository at this point in the history

  32. Fix docs spacing 

    Co-Authored-By: nerrad <[email protected]>
    @aduth @nerrad
    aduth and nerrad authored Feb 28, 2019
    Configuration menu
    Copy the full SHA
    c17179e View commit details
    Browse the repository at this point in the history