WIP: Latest post block iteration #13698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajitbohra
requested review from
gziolo,
jorgefilipecosta,
noisysocks,
Soean,
talldan and
youknowriad
as code owners
gziolo
added
[Block] Latest Posts
9 tasks
ajitbohra
requested review from
adamsilverstein,
aduth,
atimmer,
chrisvanpatten,
dmsnell,
ellatrix,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
oandregal,
notnownikki,
ntwb and
swissspidy
as code owners
ajitbohra
force-pushed
the
update/latest-post-block
branch
from
fb26a53 to
8556628
Compare
ajitbohra
removed request for
notnownikki,
ellatrix,
dmsnell,
jorgefilipecosta,
adamsilverstein,
aduth,
atimmer,
chrisvanpatten,
mapk,
mmtr,
nerrad,
oandregal,
ntwb and
swissspidy
swissspidy
reviewed
Feb 20, 2019
|
|
||
| { displayPostAuthor && | ||
| <span className="wp-block-latest-posts__post-author"> | ||
| { __( 'by' ) } { post._embedded.author[ 0 ].name } |
There was a problem hiding this comment.
Should use sprintf here and add a translator comment.
ajitbohra
force-pushed
the
update/latest-post-block
branch
from
ff2b3d0 to
8338b08
Compare
swissspidy
reviewed
Feb 20, 2019
| if( isset( $attributes['displayPostAuthor'] ) && $attributes['displayPostAuthor']) { | ||
| $list_items_markup .= sprintf( | ||
| '<span class="wp-block-latest-posts__post-author">%1$s %2$s</span>', | ||
| __( 'by' ), |
There was a problem hiding this comment.
Same as in the JS, sprintf is needed here.
|
@ajitbohra I've left feedback here which you might find useful #14627 (comment) Also are you still actively working on this PR? |
|
Closing this PR as most of the work here overlaps with #14627 which is already merged. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1594
Work In Progress