Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove options to use Classic Editor from posts list unless the Classic Editor plugin is activated #13217

Closed
wants to merge 1 commit into from

Conversation

nfmohit
Copy link
Member

@nfmohit nfmohit commented Jan 6, 2019

Description

This PR closes #12888 which reports the availability of options for usage of the Classic Editor, even if the Classic Editor plugin is not activated.

How has this been tested?

This PR has been tested by going through the following steps:

  1. Made sure the toggle to choose either Gutenberg or Classic Editor is not displayed by default.
  2. Made sure the Classic Editor option isn't available in the post actions list by default.
  3. Activated the Classic Editor plugin and made sure both of the above are displayed as expected.

Types of changes

This PR just simply uses the is_plugin_active() function to determine if the Classic Editor plugin is active, and shows the content accordingly.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@swissspidy
Copy link
Member

Shouldn‘t this code be moved completely to the Classic Editor plugin?

@gziolo
Copy link
Member

gziolo commented Feb 7, 2019

The original issue was addressed by @aduth in #13544. Thanks for spending your time trying to solve this issue. I'm closing this one, fortunately we have other PRs from you to land for the next release :)

@gziolo gziolo closed this Feb 7, 2019
@gziolo gziolo added the [Status] Not Implemented Issue/PR we will (likely) not implement. label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Not Implemented Issue/PR we will (likely) not implement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove option to use classic editor (unless classic editor plugin enabled)
3 participants