-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to ensure site is using WordPress 4.8 #1319
Add check to ensure site is using WordPress 4.8 #1319
Conversation
a02c660
to
0956714
Compare
0956714
to
b41702b
Compare
gutenberg.php
Outdated
function gutenberg_wordpress_version_notice() { | ||
echo '<div class="error"><p>'; | ||
echo __( 'Gutenburg requires WordPress 4.8 to function properly. Please upgrade WordPress before activating Gutenburg.', 'gutenberg' ); | ||
echo '</p></div>';; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a doubled semicolon here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
deactivate_plugins( array( 'gutenberg/gutenberg.php' ) ); I would not have thought to deactivate the plugin here. Is this common practice, or would it be better to keep this notice around? |
@nylen I think it's best to deactivate the plugin so that it's very clear that Gutenberg is not in use and then after WordPress has been updated, the user can activate Gutenberg and see it in all its might. |
A few fixes in the latest commits, including moving the PHP version check to a separate file, with the goal of keeping the Moving the version check to its own function also fixes the build, because the plugin was loaded via a function during PHPUnit runs, which meant that the |
Thanks for working on this. It's working well (tested by temporarily changing |
Fixes #1290