-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PollDaddy embed to Crowdsignal #13180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. This code is not working for existing polldaddy blocks. For testing this code please create a post with the old polldaddy block. After the code change, the block should be auto-transformed into the new block.
@@ -0,0 +1,2 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file should be added?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. @geekpulp You should add .vscode
to your global .gitignore
file :-)
Duplicate of #12854 ? |
Indeed a duplicate. |
Description
Change the Polldaddy embed block to Crowdsignal (Their new brand) by updating core-embeds.js.
Fixes #11517.
How has this been tested?
Tested in Safari 12.0.2, added a poll to the page using the embed. updated branded presented correctly
The standard docker environment was used for testing
This change doesn't affect other areas of the code
Screenshots
Types of changes
Content change for updated branding of a service
Checklist: