Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wp-polyfill-ecmascript BC workaround #12556

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

swissspidy
Copy link
Member

Description

Introduced in #11696, this code was marked with a note that it should be removed in Gutenberg 4.5.

This ship has now already sailed as we're currently at Gutenberg 4.6.1.

Can we remove this now? 🙂

@swissspidy swissspidy requested a review from aduth December 3, 2018 18:16
@swissspidy swissspidy added the [Type] Build Tooling Issues or PRs related to build tooling label Dec 3, 2018
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! I'd just independently come across this moments ago myself. Yes, it should be removed.

Given RC freeze, let's hold off on merging for the moment.

@swissspidy swissspidy added this to the 4.8 milestone Dec 8, 2018
@youknowriad youknowriad merged commit c523c8b into master Dec 20, 2018
@youknowriad youknowriad deleted the remove-temp-workaround branch December 20, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants