Missing Post Type supports in Options Modal #12394

imath · 2018-11-28T19:53:24Z

Featured Image is not only a Theme thing, it is possible for a custom post type to declare itself without supporting the thumbnail feature.
A custom post type can also register itself withour supporting comments and/or custom-fields.

As a result the corresponding Document panels in the editor sidebar are not displayed. The Options Modal should also avoid displaying the panel checkboxes if the custom post type does not support these 3 features

Description

To fix this issue, i've wrapped featured image, comments and custom fields checkboxes into <PostTypeSupportCheck/> components

How has this been tested?

I've tested the PR with the wp_block post type which only supports the title and editor features and check everything was still behaving the right way with the post post type.

Screenshots

Without the PR applied:

Checkboxes for featured image, comments, and custom fields are displayed although they shouldn't

With the PR applied:

The checkboxes for these 3 unsupported features are no more displayed.

Types of changes

Bug fix

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.

ajitbohra

LGTM 👍

gziolo · 2018-11-30T18:19:21Z

Should we also wrap the permalink section with check? It Was added in #12132.

imath · 2018-12-01T03:36:39Z

@gziolo Absolutely. Thanks for mentioning it. I've just updated the PR accordingly.

I've updated the Options Modal snapshots that were failing.

noisysocks · 2018-12-03T04:55:10Z

It would be nice if we didn't display the section title when there are no options underneath it. This came up in #11802 (comment) as well.

packages/edit-post/src/components/options-modal/meta-boxes-section.js

gziolo · 2018-12-03T07:37:44Z

It would be nice if we didn't display the section title when there are no options underneath it. This came up in #11802 (comment) as well.

Yes, I opened #11923 to track it.

packages/edit-post/src/components/options-modal/index.js

imath · 2018-12-05T15:29:40Z

@gziolo in 20d1669 I've succeeded to avoid the section title display, but I haven't find a better way than using a huge check 😫

Here's a screenshot:

noisysocks · 2018-12-06T00:10:36Z

Let's tackle #11923 in a seperate PR. I don't think it's urgent.

imath · 2018-12-06T02:12:30Z

Fine with me @noisysocks, should I revert 20d1669 @gziolo ?

gziolo · 2018-12-14T08:21:28Z

Fine with me @noisysocks, should I revert 20d1669 @gziolo ?

Yes, I would put it in a follow-up PR so we could iterate on it 👍

lib/client-assets.php

gziolo · 2018-12-14T08:28:34Z

packages/edit-post/src/components/options-modal/index.js

+	const hasPageAttributeSupport = get( postType, [ 'supports', 'page-attributes' ], false ) || hasTemplates;
+	let documentPanelsSection;
+
+	if ( isViewable || hasTaxonomies || hasFeaturedImageSupport || hasExcerptSupport || hasCommentsSupport || hasPageAttributeSupport ) {


It's going to be a more tricky check. All those panels can be also removed programmatically :)

imath · 2018-12-15T08:40:18Z

@gziolo I've just reverted the commit that was doing the huge check to try to solve #11923

gziolo

Looks good after all changes made 👍

gziolo · 2018-12-17T12:03:40Z

@noisysocks - do you want to perform another round of testing before we proceed? It's blocked by your review at the moment :)

No bandwidth to re-review right now

noisysocks · 2018-12-19T04:37:08Z

@gziolo: Dismissed my stale review. Am doing a support rotation this week so best not wait for me 🙂

gziolo · 2018-12-19T11:06:03Z

@imath - can you rebase with master? Travis is back to normal :)

Featured Image is not only a Theme thing, it is possible for a custom post type to declare itself without supporting the `thumbnail` feature. A custom post type can also register itself withour supporting `comments` and/or `custom-fields`. As a result the corresponding Document panels in the editor sidebar are not displayed. The Options Modal should also avoid displaying the panel checkboxes if the custom post type does not support these 3 features

…able

@noisysocks

As recommanded by @noisysocks : make sure the behavior about custom fields is consistent between WordPress 5.0 RC and the Gutenberg plugin

It should fix the failing test.

@jorgefilipecosta

…alink modal options checkbox Apply @jorgefilipecosta advice.

imath · 2018-12-19T13:47:27Z

@gziolo Sure, I've just rebased the PR 😉

lib/client-assets.php

imath · 2019-01-18T14:09:59Z

@youknowriad sorry i’ve clicked on the resolve button before posting this comment.

There’s no need to backport as it is already there these lines simply moved down a few lines. You should see the removed lines highlighted in red into the changes.

imath · 2019-01-18T14:10:31Z

And btw thanks a lot for the merge 😍

ajitbohra approved these changes Nov 29, 2018

View reviewed changes

ajitbohra requested a review from gziolo November 29, 2018 16:48

gziolo requested review from jorgefilipecosta and noisysocks November 30, 2018 10:44

gziolo added this to the 4.7 milestone Nov 30, 2018

gziolo mentioned this pull request Nov 30, 2018

Add: Permalink panel toggle mechanism. #12132

Merged

gziolo added [Feature] Extensibility The ability to extend blocks or the editing experience [Type] Enhancement A suggestion for improvement. [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Nov 30, 2018

imath force-pushed the fix/options-modal-featured-image branch from ff89e74 to 6916132 Compare December 1, 2018 03:34

noisysocks previously requested changes Dec 3, 2018

View reviewed changes

packages/edit-post/src/components/options-modal/meta-boxes-section.js Outdated Show resolved Hide resolved

gziolo mentioned this pull request Dec 3, 2018

Title for the section still renders when editor panels are removed from UI #11923

Closed

youknowriad modified the milestones: 4.7, 4.8 Dec 3, 2018

jorgefilipecosta reviewed Dec 3, 2018

View reviewed changes

packages/edit-post/src/components/options-modal/index.js Outdated Show resolved Hide resolved

imath force-pushed the fix/options-modal-featured-image branch 2 times, most recently from beda76c to 20d1669 Compare December 5, 2018 15:24

gziolo reviewed Dec 14, 2018

View reviewed changes

imath force-pushed the fix/options-modal-featured-image branch from 20d1669 to f295ac5 Compare December 15, 2018 08:36

gziolo approved these changes Dec 17, 2018

View reviewed changes

youknowriad modified the milestones: 4.8, 4.9 Dec 19, 2018

imath added 7 commits December 19, 2018 14:11

Do not use single quotes in attributes

83b0258

Display the Post permalink panel option only if the permalink is edit…

26934c7

…able

Update the Options Modal snapshots

a712ccc

Make enableCustomFields work the same as it does in core.

70f1bbd

As recommanded by @noisysocks : make sure the behavior about custom fields is consistent between WordPress 5.0 RC and the Gutenberg plugin

Remove the unused dependency to @wordpress/editor

3ab6cc1

It should fix the failing test.

Use the viewable post type property to check whether to show the perm…

3e360ae

…alink modal options checkbox Apply @jorgefilipecosta advice.

imath force-pushed the fix/options-modal-featured-image branch from f295ac5 to 3e360ae Compare December 19, 2018 13:44

youknowriad merged commit e5f398c into WordPress:master Jan 18, 2019

youknowriad reviewed Jan 18, 2019

View reviewed changes

lib/client-assets.php Show resolved Hide resolved

youknowriad pushed a commit that referenced this pull request Mar 6, 2019

Missing Post Type supports in Options Modal (#12394)

6dd5a70

youknowriad pushed a commit that referenced this pull request Mar 6, 2019

Missing Post Type supports in Options Modal (#12394)

d6087b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing Post Type supports in Options Modal #12394

Missing Post Type supports in Options Modal #12394

imath commented Nov 28, 2018 •

edited

Loading

ajitbohra left a comment

gziolo commented Nov 30, 2018

imath commented Dec 1, 2018

noisysocks commented Dec 3, 2018

gziolo commented Dec 3, 2018

imath commented Dec 5, 2018

noisysocks commented Dec 6, 2018

imath commented Dec 6, 2018

gziolo commented Dec 14, 2018

gziolo Dec 14, 2018

imath Dec 15, 2018

imath commented Dec 15, 2018

gziolo left a comment

gziolo commented Dec 17, 2018

noisysocks commented Dec 19, 2018

gziolo commented Dec 19, 2018

imath commented Dec 19, 2018

imath commented Jan 18, 2019

imath commented Jan 18, 2019

Missing Post Type supports in Options Modal #12394

Missing Post Type supports in Options Modal #12394

Conversation

imath commented Nov 28, 2018 • edited Loading

Description

How has this been tested?

Screenshots

Without the PR applied:

With the PR applied:

Types of changes

Checklist:

ajitbohra left a comment

Choose a reason for hiding this comment

gziolo commented Nov 30, 2018

imath commented Dec 1, 2018

noisysocks commented Dec 3, 2018

gziolo commented Dec 3, 2018

imath commented Dec 5, 2018

noisysocks commented Dec 6, 2018

imath commented Dec 6, 2018

gziolo commented Dec 14, 2018

gziolo Dec 14, 2018

Choose a reason for hiding this comment

imath Dec 15, 2018

Choose a reason for hiding this comment

imath commented Dec 15, 2018

gziolo left a comment

Choose a reason for hiding this comment

gziolo commented Dec 17, 2018

noisysocks commented Dec 19, 2018

gziolo commented Dec 19, 2018

imath commented Dec 19, 2018

imath commented Jan 18, 2019

imath commented Jan 18, 2019

imath commented Nov 28, 2018 •

edited

Loading