Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for css file before trying to read #12291

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Add check for css file before trying to read #12291

merged 2 commits into from
Nov 26, 2018

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Nov 25, 2018

Matches existing core trac ticket: https://core.trac.wordpress.org/ticket/45288

Fixes #12196

Description

Adds a check to see if the css file exists before trying to read it.

How has this been tested?

  • Confirm everything still works
  • Confirm no error if style file does not exist

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@youknowriad
Copy link
Contributor

Should we apply the second patch instead https://core.trac.wordpress.org/attachment/ticket/45288/themes.patch

@mkaz
Copy link
Member Author

mkaz commented Nov 25, 2018

@youknowriad oops, I didn't see the other one. Updated, agreed it's simpler.

@youknowriad youknowriad merged commit 1ee2013 into master Nov 26, 2018
@youknowriad youknowriad deleted the fix/12196/css-file-check branch November 26, 2018 09:33
@youknowriad youknowriad added this to the 4.6 milestone Nov 29, 2018
youknowriad pushed a commit that referenced this pull request Nov 29, 2018
@mkaz @youknowriad
Add check for css file before trying to read (#12291)
455ef19 
* Add check for css file before trying to read

Mirrors existing trac ticket https://core.trac.wordpress.org/ticket/45288

Fixes #12196

* Use other patch :-)
@mtias mtias added Internationalization (i18n) Issues or PRs related to internationalization efforts [Feature] Custom Editor Styles Functionality for adding custom editor styles labels Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
[Feature] Custom Editor Styles Functionality for adding custom editor styles Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaz @youknowriad @mtias