Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder: fix missing margin on block icons that are not dashicons #11947

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Placeholder: fix missing margin on block icons that are not dashicons #11947

merged 1 commit into from
Nov 16, 2018

Conversation

mtias
Copy link
Member

@mtias mtias commented Nov 15, 2018

The placeholder component is only adding margin for block icons that are dashicons.

Before:
image

After
image

@mtias mtias added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels Nov 15, 2018
@mtias mtias added this to the 4.5 milestone Nov 15, 2018
@mtias mtias mentioned this pull request Nov 15, 2018
Merged
jasmussen
jasmussen approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Ship it.

@mtias mtias merged commit 9591c90 into master Nov 16, 2018
@mtias mtias deleted the fix/block-icon-in-placeholders branch November 16, 2018 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@mtias @jasmussen