-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix url validation errors #11835
Merged
Merged
Fix url validation errors #11835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
talldan
force-pushed
the
fix/url-validation-cases
branch
from
November 14, 2018 06:41
d926d48
to
e810f59
Compare
…th a fragment to be invalid
…d instead of the first
… to and including the colon
noisysocks
approved these changes
Nov 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
@@ -60,7 +66,7 @@ export function isValidHref( href ) { | |||
} | |||
|
|||
const fragment = getFragment( trimmedHref ); | |||
if ( fragment && ! isValidFragment( trimmedHref ) ) { | |||
if ( fragment && ! isValidFragment( fragment ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
noisysocks
force-pushed
the
fix/url-validation-cases
branch
from
November 16, 2018 00:30
e810f59
to
3a9d211
Compare
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding href validation in #11286 I made a few errors, which this PR addresses
isValidFragment
(the entire href was being passed instead of just the fragment).getFragment
only captured from the last occurrence of a hash, now it captures from the first.isValidProtocol
considered a protocol with trailing forward slashes as valid. I realised this didn't match whatgetProtocol
considered a protocol (characters up to and including the colon, e.g. 'http:'), so I've made it stricter.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: