[WIP] Add alignment for latest posts block #1183
Conversation
blocks/library/latest-posts/index.js
Outdated
| </ul> | ||
| </div> | ||
| } | ||
| { /* focus && */ |
There was a problem hiding this comment.
When I uncomment this, the controls don't show up at all. Not sure why.
There was a problem hiding this comment.
I suspect that it's because you're saving the focus in the state from the initial props but when the prop is being updated the state is not being updated.
I suggest you avoid storing the focus in the local state and use the props directly.
blocks/library/latest-posts/index.js
Outdated
| key={ index } | ||
| icon={ alignment.icon } | ||
| label={ alignment.title } | ||
| data-subscript={ alignment.subscript } |
blocks/library/latest-posts/index.js
Outdated
| } | ||
| const { latestPosts, focus } = this.state; | ||
|
|
||
| const alignments = [ |
There was a problem hiding this comment.
I suggest we wait for #1019 to reuse the same toolbar here.
blocks/library/latest-posts/index.js
Outdated
| @@ -9,6 +9,9 @@ import { __ } from 'i18n'; | |||
| */ | |||
| import { registerBlockType } from '../../api'; | |||
| import { getLatestPosts } from './data.js'; | |||
| import InspectorControls from '../../inspector-controls'; | |||
| import IconButton from '../../../components/icon-button'; | |||
| import classNames from 'classnames'; | |||
There was a problem hiding this comment.
This is an external dependency, it should probably be moved to the top.
blocks/library/latest-posts/index.js
Outdated
| </div> | ||
| } | ||
| { /* focus && */ | ||
| <InspectorControls> |
There was a problem hiding this comment.
Do we really want to show up the alignments toolbar in the inspector? OR should it be it shown in the block controls? cc @jasmussen
There was a problem hiding this comment.
This is to implement the designs in #1011 (comment)
blocks/library/latest-posts/index.js
Outdated
| ) } | ||
| </ul> | ||
| <div> | ||
| { 0 === latestPosts.length ? |
There was a problem hiding this comment.
Should we rewrite this ternary like this?
{ condition
? (
<Component />
)
: (
<Component />
)
}Or maybe better
{ condition && (
<Component />
) }
{ ! condition && (
<Component />
) }Or do you find it clearer as is?
There was a problem hiding this comment.
The former is better than the latter I think, since it avoids duplicating the condition.
westonruter
added
[Feature] Blocks
|
We are adding the "display post date" and "number of posts to show" in #1191. :D Glad that we didn't work on the same thing. |
|
@lamosty but you're also adding alignment there too? |
Yeah but you did it better so I'm dropping alignment :) |
|
Closing in favor of #1803. |
This is to implement part of #1011.
This is my very first hacking with blocks, so I'm sure I'm probably doing some things wrong. Advice appreciated.
The alignment buttons should get moved into a separate component that can be re-used across all widgets.
Also need to implement support for
alignin the server-side rendering.