Fix multiselection for float elements #11748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
jasmussen
approved these changes
Nov 12, 2018
|
This PR fixes #11698. |
|
💥 |
aduth
reviewed
Nov 12, 2018
| @@ -78,8 +79,15 @@ class BlockList extends Component { | |||
| this.props.onStartMultiSelect(); | |||
| } | |||
|
|
|||
| const boundaries = this.nodes[ this.selectionAtStart ].getBoundingClientRect(); | |||
| const y = clientY - boundaries.top; | |||
| const blockContentBoundaries = getBlockDOMNode( this.selectionAtStart ).getBoundingClientRect(); | |||
There was a problem hiding this comment.
Is there any particular reason for the switch to getBlockDOMNode? Is there a hope to get rid of this this.nodes value altogether?
There was a problem hiding this comment.
The reason is that the this.nodes refer to the parent dom element which has a height = 0 for floats and I wanted the element surrounding the actual content of a block.
| const y = clientY - boundaries.top; | ||
| const blockContentBoundaries = getBlockDOMNode( this.selectionAtStart ).getBoundingClientRect(); | ||
|
|
||
| // prevent multi-selection from triggering when the selected block is a float |
There was a problem hiding this comment.
Is there anything about this which is really specific to floats?
There was a problem hiding this comment.
No, I thought I'd mention because it allows people to understand the reason for this code.
youknowriad
added a commit
that referenced
this pull request
Nov 12, 2018
* Fix multiselection for float elements * Update changelog * Add a comment to explain the fix * revert unrelated change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have float elements on the page, multi-selection triggers too often. The idea of this PR is to prevent multi-selection from triggering when the selected block is a float and the cursor is still between the top and the bottom of the block.
Fixes #11698.