Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix visibility of sibling inserter on tab focus #11685

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Nov 9, 2018

Likely regressed in #11018

This pull request seeks to resolve an issue (regression) where tab-focusing the sibling inserter would not cause it to become visible. It would still be operable by space-activation. With these changes, the button itself is now once-again visible.

Before After
Before After

Implementation notes:

The issue is that in adapting the sibling inserter to use the Inserter in #11018, the .is-visible modifier applying opacity was not correctly adapted to .editor-block-list__insertion-point-inserter.

It's unclear whether we need two separate classes each applying opacity.

Testing instructions:

Verify that, via tab navigation, the sibling inserter button is made visible once focused.

@aduth aduth added the [Feature] Inserter The main way to insert blocks using the + button in the editing interface label Nov 9, 2018
@aduth aduth added this to the 4.3 milestone Nov 9, 2018
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked great in my tests 👍
It looks like there may be a small delay/animation before the button appears though.
nov-09-2018 18-10-26

But this is for sure not a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants