Editor: Fix visibility of sibling inserter on tab focus #11685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely regressed in #11018
This pull request seeks to resolve an issue (regression) where tab-focusing the sibling inserter would not cause it to become visible. It would still be operable by space-activation. With these changes, the button itself is now once-again visible.
Implementation notes:
The issue is that in adapting the sibling inserter to use the Inserter in #11018, the
.is-visible
modifier applying opacity was not correctly adapted to.editor-block-list__insertion-point-inserter
.It's unclear whether we need two separate classes each applying opacity.
Testing instructions:
Verify that, via tab navigation, the sibling inserter button is made visible once focused.