Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Make sure the native side is refreshed after blocks Merging #11576

Merged
merged 4 commits into from
Nov 8, 2018

Conversation

daniloercoli
Copy link
Contributor

This PR fixes a problem where the native UI is not correctly refreshed when 2 blocks are merged together, resulting in one block with "old" content on the screen (Despite the datasources are updated).

To test this PR use this GB mobile PR here: .

@daniloercoli daniloercoli added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 7, 2018
…rnmobile/fix-merge-content-not-refreshed-UI

* 'master' of https://github.com/WordPress/gutenberg:
  Fix the isBeingScheduled Selector.  (#11572)
  Slot/Fill pattern with Toolbar #199 (#11115)
  Add mechanism to avoid forced child selection on blocks with templates. (#10696)
  Allow a block to disable being converted into a reusable block; Fix: Column block (#11550)
…rnmobile/fix-merge-content-not-refreshed-UI

* 'master' of https://github.com/WordPress/gutenberg:
  Add missing tests for Format API code (#11562)
  chore: Improve undo/redo no-op (#11428)
  Fix: Contrast checker: Consider fontSize large when size >=  24px instead of >= 18px (#9268)
@daniloercoli daniloercoli requested a review from gziolo November 8, 2018 08:37
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniloercoli daniloercoli merged commit 996f0fe into master Nov 8, 2018
@daniloercoli daniloercoli deleted the rnmobile/fix-merge-content-not-refreshed-UI branch November 8, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants