Framework: Set/Get default block slug #1156
Conversation
youknowriad
added
the
Framework
blocks/api/index.js
Outdated
| @@ -13,6 +13,8 @@ export { | |||
| unregisterBlockType, | |||
| setUnknownTypeHandler, | |||
| getUnknownTypeHandler, | |||
| setDefaultBlockSlug, | |||
There was a problem hiding this comment.
I got confused, because we were using slug in the same file.
There was a problem hiding this comment.
Updated but I'm still confused when to use slug and when to use name
There was a problem hiding this comment.
Related: #974
I think the intent is to replace slug with name.
There was a problem hiding this comment.
Yes, we still have a few to clean up, but going with name across the board.
youknowriad
force-pushed
the
try/default-block-config
branch
from
c79d0b7 to
4b2df79
Compare
blocks/api/registration.js
Outdated
| * | ||
| * @param {string} slug Block slug | ||
| */ | ||
| export function setDefaultBlockName( slug ) { |
There was a problem hiding this comment.
Per prior note, we should probably change this from slug to name in anticipation of #974.
youknowriad
force-pushed
the
try/default-block-config
branch
from
4b2df79 to
0ae5458
Compare
|
I'm going to merge this soon, to move forward with #1082 |
blocks/api/registration.js
Outdated
| * | ||
| * @param {string} name Block name | ||
| */ | ||
| export function setDefaultBlockName( name ) { |
There was a problem hiding this comment.
Maybe setDefaultBlock( name ) ? Could be confused as "change the name of the block which is the default", not "set the block to be used as the default".
There was a problem hiding this comment.
Yes, also redundant because you are passing the name.
youknowriad
force-pushed
the
try/default-block-config
branch
from
0ae5458 to
b8b038f
Compare
There was a problem hiding this comment.
I'm continuing to flip-flop on the naming, since we'd distinguished blocks more as instances and block type as the prototype, setDefaultBlock may not be most accurate.
Anyways, I don't want to hold this up, and we can revisit, notably in pushing along #974.
youknowriad
force-pushed
the
try/default-block-config
branch
from
b8b038f to
9ef6fcf
Compare
closes #798
In this PR, I'm adding two functions
setDefaultBlockSlugandgetDefaultBlockSlugin the same way we havesetUnknownTypeHandler.I'm hoping to use this default block as an automatic block appended to newly created blocks. #1082