Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gutenberg-mobile submodule while issues are sorted out #11301

Closed
wants to merge 2 commits into from

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Oct 31, 2018

@youknowriad
Copy link
Contributor

The issues are not happening consistently. I'd be fine with removing but I prefer if we give the mobile team some time to figure it out and see if it can be improved.

@danielbachhuber
Copy link
Member Author

prefer if we give the mobile team some time to figure it out and see if it can be improved.

Can we please remove for now, and then restore when it's improved? As it stands, it's blocking the development workflow for multiple people.

@danielbachhuber
Copy link
Member Author

I sorted my more immediate problem by including npm run mobile-submodule-update in my build script.

@danielbachhuber danielbachhuber deleted the rm-mobile-submodule branch October 31, 2018 14:37
@earnjam
Copy link
Contributor

earnjam commented Oct 31, 2018

Gutenberg includes gutenberg-mobile, which includes gutenberg, which includes gutenberg-mobile, which includes gutenberg

image

Seems like there has to be a better way

@youknowriad
Copy link
Contributor

I know it's not great but my point is that we should try to be inclusive with the mobile team. Including their tests mean we don't break mobile inadvertently. We're all on the same boat, we should try to merge the repositories I think.

That doesn't mean we can't do quick wins for now.

@youknowriad
Copy link
Contributor

I personally prefer this approach for now #11304

@danielbachhuber
Copy link
Member Author

I personally prefer this approach for now

Yep, seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants