Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Alt + F10 (navigate to the nearest toolbar) to the shortcut docs and modal #11096

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Add Alt + F10 (navigate to the nearest toolbar) to the shortcut docs and modal #11096

merged 1 commit into from
Oct 30, 2018

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Oct 26, 2018

Description

Found this undocumented keyboard shortcut the other day, it seems to still work absolutely fine. This PR adds it to our docs and the shortcut modal.

How has this been tested?

  • Manual testing

Screenshots

screen shot 2018-10-26 at 5 26 32 pm

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@talldan talldan self-assigned this Oct 26, 2018
@talldan talldan added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Developer Documentation Documentation for developers [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Oct 26, 2018
@talldan talldan mentioned this pull request Oct 26, 2018
Closed
@talldan
Copy link
Contributor Author

talldan commented Oct 26, 2018

Potentially want to hold off merging this or advertising this shortcut until #10907 is fixed.

aduth
aduth approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good. The behavior can work as-is, though it's buggy and inconsistent.

I personally think it'd be okay to ship, even as a motivation to work out a resolution of the remaining bugginess.

@talldan talldan added this to the 4.2 milestone Oct 30, 2018
@talldan talldan merged commit ca4e9fd into master Oct 30, 2018
@talldan talldan deleted the add/toolbar-nav-shortcut-docs branch October 30, 2018 08:14
@mtias
Copy link
Member

mtias commented Oct 30, 2018

Thanks!

@mtias mtias added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees

@talldan talldan

Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Developer Documentation Documentation for developers [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@talldan @mtias @aduth