Try different block descriptions #10971
Conversation
| @@ -10,7 +10,7 @@ export const name = 'core/preformatted'; | |||
| export const settings = { | |||
| title: __( 'Preformatted' ), | |||
|
|
|||
| description: __( 'Add text that respects your spacing and tabs, and also allows styling.' ), | |||
| description: __( 'Add custom HTML code and preview it as you edit.' ), | |||
There was a problem hiding this comment.
This doesn't make sense for the Preformatted block. There is no "preview" mode; the Preformatted block is just for preformatted text.
There was a problem hiding this comment.
Good point. This seems like it wasn't updated to the latest suggestion in this comment:
Add text that respects your spacing and tabs, and also allows styling.
| @@ -9,7 +9,7 @@ export const name = 'core/separator'; | |||
| export const settings = { | |||
| title: __( 'Separator' ), | |||
|
|
|||
| description: __( 'Insert a horizontal line where you want to create a break between ideas.' ), | |||
| description: __( 'Create a break between ideas or sections with a horizontal line.' ), | |||
There was a problem hiding this comment.
It's not always a line. Even a core style uses 3 dots.
There was a problem hiding this comment.
Good point. How about:
Create a break between ideas or sections with a horizontal separator.
There was a problem hiding this comment.
The gutenberg-mobile subfolder tricked me, I updated more descriptions but in the wrong folder :P
| @@ -17,7 +17,7 @@ export const name = 'core/spacer'; | |||
| export const settings = { | |||
| title: __( 'Spacer' ), | |||
|
|
|||
| description: __( 'Add an element with empty space and custom height.' ), | |||
| description: __( 'Add white space between blocks and customize its height.' ), | |||
There was a problem hiding this comment.
Wouldn't "empty space" be just a bit clearer (and easier to translate)?
| @@ -15,7 +15,7 @@ export const name = 'core/verse'; | |||
| export const settings = { | |||
| title: __( 'Verse' ), | |||
|
|
|||
| description: __( 'A block for haiku? Why not? Blocks for all the things! (See what we did here?)' ), | |||
| description: __( 'Insert haiku. Use special spacing formats. Or quote song lyrics. (See what we did here?)' ), | |||
There was a problem hiding this comment.
This is not a valid haiku, as far as I can tell. The first line has 4 syllables, but the third line has 5 syllables. They should both have the same number of syllables.
| @@ -96,7 +96,7 @@ const schema = { | |||
| export const settings = { | |||
| title: __( 'Image' ), | |||
|
|
|||
| description: __( 'They’re worth 1,000 words! Insert a single image.' ), | |||
| description: __( 'Insert an image for visual color.' ), | |||
There was a problem hiding this comment.
Shouldn't this description be a bit more like the Video one? Same goes for the Audio description.
|
Can we get this rebased and refreshed with the latest descriptions in #10919 to include in 4.2? |
|
For information, I'm going to update the PR |
youknowriad
force-pushed
the
try/block-description-edits
branch
from
2c5e12b to
1ed4aa7
Compare
|
Pushed an update. How does it look now? |
|
I left a few comments based on Zebs thoughts, let's get those in and ship, then we can enhance further as we go. |
youknowriad
force-pushed
the
try/block-description-edits
branch
from
1ed4aa7 to
a97364a
Compare
This follows the latest suggestions by @alexislloyd in #10919.
youknowriad
force-pushed
the
try/block-description-edits
branch
from
a97364a to
433f128
Compare
|
Thanks for the iterations @youknowriad. |
|
Looks like there was a PR that got merged without upgrading |
mtias
added
[Type] Enhancement
This follows the latest suggestions by @alexislloyd in #10919.
The section it doesn't do is this:
I think this needs some dev help to make happen. @mtias looping you in just incase here.