Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changelog issue. #10953

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Fix changelog issue. #10953

merged 3 commits into from
Oct 23, 2018

Conversation

jasmussen
Copy link
Contributor

This PR fixes a typo in a previous changelog change, which happened because the 5.0.1 version was already published. This bumps it to 5.0.2.

Let me know if this looks good.

@jasmussen
Fix changelog issue.
e998a90 
This PR fixes a typo in a previous changelog change, which happened because the 5.0.1 version was already published. This bumps it to 5.0.2.
@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Oct 23, 2018
@jasmussen jasmussen self-assigned this Oct 23, 2018
@jasmussen jasmussen mentioned this pull request Oct 23, 2018
Merged
ocean90
ocean90 requested changes Oct 23, 2018
View reviewed changes
packages/editor/CHANGELOG.md Outdated
@@ -1,4 +1,4 @@
## 5.0.1 (2018-10-22)
## 5.0.2 (2018-10-22)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the existing entry you have add yours as unreleased like this:

## 5.0.2 (unreleased)

### Polish
- Add animated logo to preview interstitial screen.

## 5.0.1 (2018-10-22)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this? e92caad

Thanks for the patience. I've only ever published one project to NPM and it was a while ago. I'll get this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen No worries. 🙂Now you only have to readd the ## 5.0.1 (2018-10-22) line and then it's good to go.

@swissspidy
Copy link
Member

Was there no changelog for 5.0.1? Now with this PR it goes straight from 5.0.0 to 5.0.2 in the changelog.

@jasmussen
Copy link
Contributor Author

It doesn't seem like a changelog item was added for 5.0.1, I'm not really sure where the process broke down as I'm still new to this.

@jasmussen
Copy link
Contributor Author

jasmussen commented Oct 23, 2018 •
edited
Loading

Pushed a change. Okay to go now? Thanks again for the patience.

@ocean90
Copy link
Member

ocean90 commented Oct 23, 2018

Thanks @jasmussen!

@jasmussen jasmussen merged commit a563dc7 into master Oct 23, 2018
@jasmussen jasmussen deleted the fix/changelog-issue branch October 23, 2018 15:24
@jasmussen jasmussen added this to the 4.2 milestone Oct 23, 2018
@swissspidy swissspidy mentioned this pull request Oct 23, 2018
Merged
4 tasks
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
@jasmussen @antpb
Fix changelog issue. (WordPress#10953)
e84156c 
* Fix changelog issue.

This PR fixes a typo in a previous changelog change, which happened because the 5.0.1 version was already published. This bumps it to 5.0.2.

* Address feedback.

* Address feedback?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocean90 ocean90 ocean90 approved these changes

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

@jasmussen jasmussen

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jasmussen @swissspidy @ocean90