Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactNative - Block splitting - Handle the case when the split occurs at the trailing or leading edge #10737

Merged
merged 1 commit into from
Oct 18, 2018
Merged

ReactNative - Block splitting - Handle the case when the split occurs at the trailing or leading edge #10737

merged 1 commit into from
Oct 18, 2018

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Oct 18, 2018 •
edited
Loading

This PR adds the code that handles the case when the split occurs at the trailing or leading edge of the field.

Also remove an hack for the Android platform in regards to cursor position.

Detailed testing steps will be provided in the other PR in the GB mobile project. Briefly:

  • Put the cursor at the end of a para block and hit enter. It should add an empty block after the current.
  • Put the cursor at the end of a para block and hit Enter. It should add a block after the current with all the content. Current block will be blank after.
  • Put the cursor in the middle of a block, and hit Enter.

@daniloercoli daniloercoli added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 18, 2018
@daniloercoli daniloercoli mentioned this pull request Oct 18, 2018
Merged
diegoreymendez
diegoreymendez approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via wordpress-mobile/gutenberg-mobile#176

@diegoreymendez diegoreymendez merged commit 1e82348 into master Oct 18, 2018
@diegoreymendez diegoreymendez deleted the rnmobile/split-at-trailing-or-leading-edge branch October 18, 2018 15:10
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
@daniloercoli @antpb
Handle the case when the split occurs at the trailing or leading edge…
17879ec 
… of the field. (WordPress#10737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniloercoli @diegoreymendez