Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update REST Search controller to use 'wp/v2' namespace #10670

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Update REST Search controller to use 'wp/v2' namespace #10670

merged 2 commits into from
Oct 18, 2018

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber requested a review from a team October 17, 2018 00:44
@danielbachhuber danielbachhuber added this to the 4.1 - UI freeze milestone Oct 17, 2018
@danielbachhuber danielbachhuber added the REST API Interaction Related to REST API label Oct 17, 2018
gziolo
gziolo approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

gziolo
gziolo reviewed Oct 18, 2018
View reviewed changes
packages/components/src/server-side-render/README.md
@@ -32,5 +32,5 @@ Output uses the block's `render_callback` function, set when defining the block.

## API Endpoint

The API endpoint for getting the output for ServerSideRender is `/gutenberg/v1/block-renderer/:block`. It accepts any params, which are used as `attributes` for the block's `render_callback` method.
The API endpoint for getting the output for ServerSideRender is `/wp/v2/block-renderer/:block`. It accepts any params, which are used as `attributes` for the block's `render_callback` method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was missed in #10662

@gziolo gziolo merged commit 1dfae32 into master Oct 18, 2018
@gziolo gziolo deleted the update-wp-v2-search branch October 18, 2018 08:46
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
@danielbachhuber @antpb
Update REST Search controller to use 'wp/v2' namespace (WordPress#10670)
e48851c 
* Update REST Search controller to use 'wp/v2' namespace

* Docs: Update REST API url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
REST API Interaction Related to REST API
Projects
None yet
Milestone
4.1 - UI freeze
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @gziolo