Make possible to overwrite the globally defined colors in PanelColorSettings #10457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Love love love it! Thanks @jorgefilipecosta! |
jorgefilipecosta
force-pushed
the
update/make-PanelColorSettings-accept-overwrite-of-colors
branch
2 times, most recently
from
1e8731f to
42b4476
Compare
4 tasks
talldan
approved these changes
Oct 17, 2018
| `; | ||
|
|
||
| exports[`PanelColorSettings should render a color panel if at least one setting specifies some colors to choose 1`] = ` | ||
| <Component |
There was a problem hiding this comment.
I noticed that the component used in the test is wrapped with ifCondition, which caused the shallow render to not render the children of PanelColorSettings (making the tests a bit obsolete). I found that you can use wrapper.dive() in enzyme to render the children, so I've pushed a commit with some additional snapshots.
| @@ -17,58 +17,107 @@ import ColorPaletteControl from '../color-palette/control'; | |||
| import withColorContext from '../color-palette/with-color-context'; | |||
| import { getColorObjectByColorValue } from '../colors'; | |||
|
|
|||
| const customColorsDisableForSetting = ( disableCustomColors, colorSetting ) => { | |||
There was a problem hiding this comment.
nitpick: the name of this function could start with 'has' like the other two functions, and should probably use the adjective 'disabled' instead of the verb 'disable'.
…ed colors settings (colors arrays and disableCustomColors) in PanelColorSettings. The overwrite can be global for all the color panels of the component or local per each settings panel.
jorgefilipecosta
force-pushed
the
update/make-PanelColorSettings-accept-overwrite-of-colors
branch
from
6719168 to
80184f8
Compare
jorgefilipecosta
deleted the
update/make-PanelColorSettings-accept-overwrite-of-colors
branch
|
I'll update my deprecation PR for the correct version numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to overwrite the globally defined colors (colors arrays and disableCustomColors) in PanelColorSettings.
The overwrite can be global for all the color panels of the component or local per each settings panel.
This PR makes sure that we offer all the functionality that the combination of wp.editor.PanelColor and wp.components.PanelColor had. Making it possible to deprecate these components and unify the color UI components. Deprecation PR created by @chrisvanpatten is available in #10391.
How has this been tested?
I checked that the blocks using colors (button, paragraph, pull quote still work as before).
I tried a theme that sets the colors or disables custom colors, and everything worked as before.
I created the test block available in https://gist.github.com/jorgefilipecosta/ac1d68e492869465b054868baac60df2 and checked that the definition overwrites specified were correctly applied.