-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix classic block toolbar regression #10443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise looks good. I would love to have 👍 from @jasmussen to ensure it looks exactly the same as in 3.9 :)
Looking now. |
Looks good, but it also looks like there's a separate regression. Master: This branch: 3.9: Notice how the paragraphs below, in both cases, has a lineheight of 1.3 as opposed to 1.8 as it should. It looks like a lineheight rule from .mce-content-body is bleeding in: This is supposed to fix it: But obviously that's not working anymore. Adding to the p itself should fix it: But that's also not a nice fix, especially since we want editor styles to be as close to the stock experience as possible. It would be nice to figure out why that extra rule is suddenly there. |
@jasmussen I'm not having the same results as you in this branch. Could you have tested "master" instead of this branch? |
Sorry forgot to mention, you have to click the classic block so it initializes, only then the line height issue persists. This is an issue both in this branch and master and okay to fix separately. I have to help with the kids but can look later. |
@@ -33,3 +31,7 @@ ul ul, | |||
ol ul { | |||
list-style-type: circle; | |||
} | |||
|
|||
.mce-content-body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
An ideal fix would be to not load /wp-includes/js/tinymce/skins/lightgray/content.inline.min.css
at all. I think that should also fix this issue.
But if we can't do that, this seems like the better fix.
a8aa6ad
to
979261b
Compare
Fix a small visual regression in the classic block's toolbar introduced in #10397