Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Captions are positioned incorrectly. #9752

Closed
kjellr opened this issue Sep 10, 2018 · 1 comment
Closed

Gallery Captions are positioned incorrectly. #9752

kjellr opened this issue Sep 10, 2018 · 1 comment
Assignees
@jasmussen
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@kjellr
Copy link
Contributor

kjellr commented Sep 10, 2018

Describe the bug

Gallery captions are positioned incorrectly in the master branch:

screen shot 2018-09-10 at 10 43 39 am

They should be aligned to the bottom of the image:

screen shot 2018-09-10 at 10 50 08 am

I'm wondering if maybe this was introduced alongside #9622? (cc @jasmussen)

To Reproduce

  1. Add a gallery block
  2. Click on an image to begin adding a caption.
  3. Notice that the gradient and caption is incorrectly placed.

Tested in

Mac OS 10.13.6, Safari 11.1.2 (13605.3.8), Chrome 69.0.3497.81
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Type] Regression Related to a regression in the latest release labels Sep 10, 2018
@jasmussen jasmussen self-assigned this Sep 10, 2018
kjellr added a commit that referenced this issue Sep 10, 2018
@kjellr
Adjust gallery caption flex alignment.
8eef28c 
Gallery captions are meant to appear at the bottom of gallery items, but a recent change in #9622 changed that and introduced a visual bug. This sets things back to the way they were before.

Fixes #9752
@kjellr kjellr mentioned this issue Sep 10, 2018
Merged
@kjellr
Copy link
Contributor Author

kjellr commented Sep 10, 2018

Looks like this is the culprit:

b1aef9c#diff-9ffb7855d1c617407b369408c6c01fe4L22

@jasmussen: I opened #9762 with a fix, but wanted to run it by you as I couldn't discern the reason for that adjustment in #9622.

(FWIW, Galleries with captions in IE11 look 100% weird in my testing due to #8594)

jasmussen pushed a commit that referenced this issue Sep 13, 2018
@kjellr @jasmussen
Adjust gallery caption flex alignment (#9762)
ebe0c82 
* Adjust gallery caption flex alignment.

Gallery captions are meant to appear at the bottom of gallery items, but a recent change in #9622 changed that and introduced a visual bug. This sets things back to the way they were before.

Fixes #9752

* Fix issue with non-cropped galleries.

* Fix issues with captions.

Props for the code to @webmandesign.

* Fix another issue with captions.

* Set a bottom position value gallery captions.
@yassine4999 yassine4999 mentioned this issue Nov 30, 2023
Open
@soloinovator soloinovator mentioned this issue Nov 30, 2023
Open
@petrescugit petrescugit mentioned this issue Nov 30, 2023
Open
@captainbarber99 captainbarber99 mentioned this issue Nov 30, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjellr @jasmussen