Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide keyboard shortcuts on mobile #9050

Closed
tofumatt opened this issue Aug 16, 2018 · 0 comments
Closed

Hide keyboard shortcuts on mobile #9050

tofumatt opened this issue Aug 16, 2018 · 0 comments
Assignees
@tofumatt
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Enhancement A suggestion for improvement.
Milestone
3.7

Comments

@tofumatt
Copy link
Member

As mentioned in
#8756 (comment), we should hide keyboard shortcuts for mobile viewports.

While @jasmussen asked "What about desktop users with very narrow viewports?", I think the answer is "at those screen sizes, we should just highlight the menu option and not the shortcut". 😄
@tofumatt tofumatt added [Type] Enhancement A suggestion for improvement. Mobile Web Viewport sizes for mobile and tablet devices labels Aug 16, 2018
@tofumatt tofumatt added this to the 3.7 milestone Aug 16, 2018
@tofumatt tofumatt self-assigned this Aug 16, 2018
tofumatt added a commit that referenced this issue Aug 16, 2018
@tofumatt
feat: Hide keyboard shortcuts on mobile screens
52e3ecb 
Fix #9050.
@tofumatt tofumatt mentioned this issue Aug 16, 2018
Merged
4 tasks
youknowriad pushed a commit that referenced this issue Aug 16, 2018
@tofumatt @youknowriad
feat: Hide keyboard shortcuts on mobile screens (#9051)
2399173 
* feat: Hide keyboard shortcuts on mobile screens

Fix #9050.

* docs: Clarify reasoning for wanting more space

* Add min-width to menu.

This fixes a regression I introduced in https://github.com/WordPress/gutenberg/pull/8756/files#diff-dcb8eefee4aaf82c9ddb042494547527R158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
3.7
Development

No branches or pull requests
1 participant
@tofumatt