-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ::before (pseudo elements) instead of :before (pseudo classes) #8618
Labels
[Type] Code Quality
Issues or PRs that relate to code quality
Comments
tomjn
added a commit
to tomjn/gutenberg
that referenced
this issue
Aug 6, 2018
noisysocks
pushed a commit
that referenced
this issue
Aug 7, 2018
Partially addressed by #8630. Once there's a lint rule added we can close this issue 🙂 – see #8630 (comment) for context. |
Should we do the same for |
Yes. 😄 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should be using
::before
across the project instead of:before
; browser support is there and it's more semantically correct. See:#8588 (comment)
We should probably add a lint warning to the project as well so future devs don't use
:before
instead of::before
by mistake, once this is closed.The text was updated successfully, but these errors were encountered: