Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ::before (pseudo elements) instead of :before (pseudo classes) #8618

Closed
tofumatt opened this issue Aug 6, 2018 · 4 comments · Fixed by #8647
Closed

Use ::before (pseudo elements) instead of :before (pseudo classes) #8618

tofumatt opened this issue Aug 6, 2018 · 4 comments · Fixed by #8647
Assignees
@tofumatt
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@tofumatt
Copy link
Member

tofumatt commented Aug 6, 2018

We should be using ::before across the project instead of :before; browser support is there and it's more semantically correct. See:
#8588 (comment)

We should probably add a lint warning to the project as well so future devs don't use :before instead of ::before by mistake, once this is closed.
@tofumatt tofumatt added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 6, 2018
@tofumatt tofumatt self-assigned this Aug 6, 2018
@tofumatt tofumatt mentioned this issue Aug 6, 2018
Merged
tomjn added a commit to tomjn/gutenberg that referenced this issue Aug 6, 2018
@tomjn
swaps out the CSS2 :before with the CSS3 ::before, see WordPress#8618
94aee2e
@tomjn tomjn mentioned this issue Aug 6, 2018
Merged
noisysocks pushed a commit that referenced this issue Aug 7, 2018
@tomjn @noisysocks
swaps out the CSS2 :before with the CSS3 ::before, see #8618 (#8630)
d54396c
@noisysocks
Copy link
Member

Partially addressed by #8630. Once there's a lint rule added we can close this issue 🙂 – see #8630 (comment) for context.

@noisysocks noisysocks mentioned this issue Aug 7, 2018
Merged
@tomjn
Copy link
Contributor

tomjn commented Aug 7, 2018

Should we do the same for :after vs ::after?

@tofumatt
Copy link
Member Author

tofumatt commented Aug 7, 2018

Yes. 😄

@ntwb
Copy link
Member

ntwb commented Aug 7, 2018

::after is taken care of in #8647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add stylelint for SCSS linting WordPress/gutenberg
4 participants
@tomjn @tofumatt @noisysocks @ntwb