Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and Drop deadzones #8540

Closed
tomjn opened this issue Aug 5, 2018 · 9 comments
Closed

Drag and Drop deadzones #8540

tomjn opened this issue Aug 5, 2018 · 9 comments
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Enhancement A suggestion for improvement.

Comments

@tomjn
Copy link
Contributor

tomjn commented Aug 5, 2018

Describe the bug

When dragging and dropping there are 2 equivalent but separate zones that show as a thin blue bar, and a large deadzone inbetween that if dropped on, nothing happens

To Reproduce

https://youtu.be/__GuOHcaD3s

Expected behavior

I expected that dragging the block in between 2 paragraph blocks would insert it when I let go of the block

I also expected significantly larger drop zones, and indicators. I was also surprised to see 2 separate targets, the bottom of the block and the top of the next block, which made little sense, as both are equivalent. In some scenarios there was even additional insertion points on blocks that did not have child block capability. The targets were also difficult to target, being very thin and small

Screenshots

https://youtu.be/__GuOHcaD3s

Desktop (please complete the following information):

  • OS: MacOS High Sierra
  • Browser Chrome
  • Version 68

Additional context

  • Gutenberg v3.4
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Aug 6, 2018
@designsimply
Copy link
Member

Adding a screenshot for reference:

screen shot 2018-08-06 at mon aug 6 5 29 43 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=14134&action=edit running WordPress 4.9.8 and Gutenberg 3.4.0 using Chrome 67.0.3396.99 on macOS 10.13.6.

@talldan
Copy link
Contributor

talldan commented Sep 21, 2018

I've closed #9821 as a duplicate. Thought I'd drop the gif demonstrating the issue from there in here:
45422690-40e40a80-b691-11e8-8cc8-7bda4e3859cd

@tomjn
Copy link
Contributor Author

tomjn commented Sep 22, 2018

Of note, I'm not sure why the space inbetween the first and second block has 2 target zones

@JJJ
Copy link
Contributor

JJJ commented Oct 22, 2018

Hey @tomjn! I found this separately. I agree it all feels very wrong.

I’d go a step farther and say that this feature feels so wrong, breaking it down into smaller separate tasks is going to be hard to do, but required for it to be improved. So many little oddities.

It alone would be a blocker to merging into WordPress core for 5.0 if it were under my influence.

At the risk of stating the obvious (into an echo chamber), dragging and dropping blocks is a basic fundamental property of building with them. Everything from the original printing press to Minecraft requires easily and comfortably rearranging blocks in an intuitive way – this is not even close to there yet.

Seeing no movement and no response on this for 90 days is also worrisome.

What’s the polite way to get more eyes on this?

@mrwweb
Copy link

mrwweb commented Nov 10, 2018

I spent the last week thinking that drag and drop didn't work because the discoverability of the drag handle is extremely high but the discoverability of the drop zones is extremely low.

My assumption was that I could drag a handle directly up and down because that's where the handle is and that's the direction I want to move things. The above drag and drop WILL NOT WORK:

arrow showing expected drag direction

To be clear, you can only drop blocks in between other blocks, not by placing the handle above the handle of other blocks.

If this can't be drastically improved, I think the behavior should be pulled and only the up/down arrow buttons should remain.

@talldan
Copy link
Contributor

talldan commented Nov 12, 2018

@mrwweb I regularly make the mistake of dragging directly up and down as well.

WRT the original report, I think this gif makes it a bit clearer what's happening (edit- ok, it was supposed to be clearer, but because the image quality is so low you can't see the grey area left behind by the dragged block 🤦‍♂️ ):
dragdrop

Each block is itself the dropzone, and when you drag a block over another, the top or bottom edge of the block's dropzone is highlighted depending on which one you're closer to.

I think what most would expect is that the dropzone is instead the space between the block instead of the block itself. I'm not sure that would work well either, since the space left behind by the dragged block would still have multiple dropzones.

@tomjn
Copy link
Contributor Author

tomjn commented Nov 12, 2018 via email

@talldan
Copy link
Contributor

talldan commented Nov 13, 2018

@tomjn That was my interpretation initially (just as a user), but the dropzone being the block explains why we can't drop between blocks:
screen shot 2018-11-13 at 3 24 29 pm

@youknowriad
Copy link
Contributor

Drag and drop behavior changed on WP 5.4 and I believe there's no dead zones now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants