Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Block: Change the "Source Type" label to "Image Size" #7855

Closed
BronsonQuick opened this issue Jul 10, 2018 · 3 comments
Closed

Image Block: Change the "Source Type" label to "Image Size" #7855

BronsonQuick opened this issue Jul 10, 2018 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Feedback Needs general design feedback. [Type] Copy Issues or PRs that need copy editing assistance

Comments

@BronsonQuick
Copy link
Contributor

Issue Overview

While testing the image block I thought that "Source Type" isn't a very user friendly term and "Image Size" would be more user friendly. Even the const used refers to sizes. e.g. const availableSizes = this.getAvailableSizes(); so it makes sense to change this label.

Steps to Reproduce

  1. Insert an Image block.
  2. Upload or Select an Image to use.
  3. Observe the "Source Type" label.

Expected Behavior

The label should say "Image Size".

Screenshots / Video

source-type

Additional Info

Gutenberg @ c72f5b4
@BronsonQuick BronsonQuick mentioned this issue Jul 10, 2018
Merged
4 tasks
@designsimply designsimply added [Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Jul 10, 2018
@designsimply designsimply changed the title Image: Change the "Source Type" label to "Image Size" Image Block: Change the "Source Type" label to "Image Size" Jul 10, 2018
@paaljoachim
Copy link
Contributor

What about just removing the Source Type (image size) option? Since we can easily resize the image directly in the image block layout.

@michelleweber
Copy link

If you do keep this setting, +1 on changing it to "Image size." (But I'd also love to look at these settings and immediately understand the difference between "image size" and "image dimensions," which seem like they should be the same thing.)

@designsimply designsimply removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jul 10, 2018
@mtias mtias added [Feature] Media Anything that impacts the experience of managing media Needs Design Feedback Needs general design feedback. labels Jul 19, 2018
@sarahmonster sarahmonster mentioned this issue Jul 20, 2018
Closed
@sarahmonster
Copy link
Member

+1 for changing the setting name. +2 for getting rid of it altogether or combining it with Image Dimensions control.

ntwb pushed a commit that referenced this issue Jul 20, 2018
@ntwb
Change the text label from "Source Type" to "Image Size" (#7856)
fe92794 
Fixes #7855.

## Description
I've changed the label on the Image block from "Source Type" to "Image Size".

## How has this been tested?
I ran `npm run dev` to test this.

## Screenshots
<img width="589" alt="image-size" src="https://user-images.githubusercontent.com/1377956/42490653-d9d0e20a-8454-11e8-9408-0cb3c12f553b.png">

## Types of changes
It's just a label change as "Source Type" is a developer friendly term but not a user friendly term.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Feedback Needs general design feedback. [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sarahmonster @mtias @designsimply @BronsonQuick @paaljoachim @michelleweber