Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button block: text should word-wrap if needed #7843

Closed
GlennMartin1 opened this issue Jul 9, 2018 · 4 comments · Fixed by #12205
Closed

Button block: text should word-wrap if needed #7843

GlennMartin1 opened this issue Jul 9, 2018 · 4 comments · Fixed by #12205
Labels
[Block] Buttons Affects the Buttons Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.0.x F...

Comments

@GlennMartin1
Copy link

Describe the bug
Depending on screen size, buttons must word-wrap.

Screenshots
This screenshot says it all:
screenshot_2018-07-09-16-55-45
@designsimply designsimply changed the title [3.2 mobile] button text must word-wrap if needed... Button block: text should word-wrap if needed Jul 10, 2018
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Jul 10, 2018
@designsimply
Copy link
Member

Tested and confirmed using the following sample button text:

Check out our selection testing testing testing testing

screen shot 2018-07-10 at tue jul 10 1 09 05 pm
Seen at http://alittletestblog.com/2018/07/10/button-block-word-wrap-test/ running WordPress 4.9.7 and Gutenberg 3.2.0 using Chrome 67.0.3396.99 with 'Toggle device toolbar' set to 'iPhone 5/SE' on macOS 10.13.5.

@GlennMartin1
Copy link
Author

This also affects desktop, NOT unique to mobile devices.

@GlennMartin1
Copy link
Author

persists in 3.3

@GlennMartin1
Copy link
Author

Persists in 4.0.

Seems like this should be a simple fix.

@mtias mtias added the [Block] Buttons Affects the Buttons Block label Nov 21, 2018
@mtias mtias added this to the WordPress 5.0.x Follow Ups milestone Nov 21, 2018
jasmussen pushed a commit that referenced this issue Nov 22, 2018
Improve button block styles and wrap.
61f2c84 
This PR fixes #7843, and also simplifies the styles a bit. It also fixes an overflow issue with long text in variations. Finally, it makes a single line button have a proper pillshape.
@jasmussen jasmussen mentioned this issue Nov 22, 2018
Merged
youknowriad pushed a commit that referenced this issue Nov 23, 2018
@jasmussen @youknowriad
Improve button block styles and wrap. (#12205)
1f57485 
This PR fixes #7843, and also simplifies the styles a bit. It also fixes an overflow issue with long text in variations. Finally, it makes a single line button have a proper pillshape.
youknowriad pushed a commit that referenced this issue Nov 29, 2018
@jasmussen @youknowriad
Improve button block styles and wrap. (#12205)
c6604ce 
This PR fixes #7843, and also simplifies the styles a bit. It also fixes an overflow issue with long text in variations. Finally, it makes a single line button have a proper pillshape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Buttons Affects the Buttons Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.0.x Follow Ups
Development

Successfully merging a pull request may close this issue.

Improve button block styles and wrap. WordPress/gutenberg
3 participants
@mtias @designsimply @GlennMartin1