Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block captions are not synced with media library #7193

Closed
jeremyfelt opened this issue Jun 6, 2018 · 4 comments
Closed

Image block captions are not synced with media library #7193

jeremyfelt opened this issue Jun 6, 2018 · 4 comments
Labels
[Status] Needs More Info Follow-up required in order to be actionable.

Comments

@jeremyfelt
Copy link
Member

Describe the bug

Images in the media library have caption data that can be entered. When images are inserted into content, the caption follows the image.

In the classic editor, when the caption is edited in post content, it also changes in the media library.

In Gutenberg, when the caption is edited in post content, it does not change in the media library.

In both the classic editor and Gutenberg, when the caption is edited by editing the image itself, the updated caption is applied to the content.

To Reproduce
Steps to reproduce the behavior:

  1. Open a new post
  2. Add an image block
  3. Select a media item
  4. Edit the media item's caption in attachment details
  5. Click "Select" to insert the media
  6. Edit the caption directly in the block
  7. Edit the image
  8. Look at the caption in attachment details

Expected behavior

Based on current behavior, I would expect that the caption text is synchronized between the image in content and the media library.

Additional context

  • Gutenberg 3.0.1
  • WordPress 4.9.6
@danielbachhuber
Copy link
Member

In the classic editor, when the caption is edited in post content, it also changes in the media library.

Are you sure about this? I don't believe it's the case. As soon as an image is inserted into the post, its caption and alt text are properties of the post, no longer the attachment database object.

Can you share a GIF or some screenshots of the behavior?

@danielbachhuber danielbachhuber added the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 6, 2018
@jeremyfelt
Copy link
Member Author

Bah, I was fooled. :)

When editing an image via post content in the classic editor, an "Image Details" modal comes up that shows the caption from post content. It does not sync with the media item's caption.

When editing an image via post content in Gutenberg, the "Select or Upload Media" modal comes up. This allows you to override the caption currently in post content, but does not sync from post content.

So more of a behavior change than a bug it seems like.

Classic editor:
old-image-captions

Gutenberg:
image-captions

@danielbachhuber
Copy link
Member

@jeremyfelt No bug then?

@jeremyfelt
Copy link
Member Author

Yeah, just some initial confusion for somebody used to a workflow. It's documented now though. :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

2 participants