Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Block: Incorrect display of color-contrast warning #52800

Closed
kathrynwp opened this issue Jul 20, 2023 · 2 comments
Closed

Cover Block: Incorrect display of color-contrast warning #52800

kathrynwp opened this issue Jul 20, 2023 · 2 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@kathrynwp
Copy link

Description

In WP 6.3-RC1, the Cover block incorrectly displays a color-contrast warning, where it did not in 6.2.2.

Step-by-step reproduction instructions

  1. Activate Twenty Twenty-Three
  2. Add a Cover block to a page or post
  3. Add a dark background image to the block (without modifying any opacity or other settings)
  4. Add some text (without modifying the default colours)

Result

This message is displayed:

This color combination may be hard for people to read. Try using a brighter background color and/or a darker text color.

Expected

No color-contrast warning should be displayed if there are no contrast issues.

Screenshots, screen recording, code snippet

6.3-RC1:

Add_New_Page_‹_LearnWP_—_WordPress

Compare to 6.2.2:

Add_New_Page_‹_Testing_Testing_123_—_WordPress_and_Messenger

Environment info

  • WP 6.3-RC1
  • Twenty Twenty-Three 1.1
  • No plugins active except WP Beta Tester

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image [a11y] Color Contrast labels Jul 20, 2023
@kathrynwp
Copy link
Author

In addition, I noticed that changing the colour of the Paragraph block within the Cover block to a colour that's actually not contrasty enough removes the contrast warning.

In other words:

The contrast warning is present when it shouldn't be, and absent when it should be there.

Edit_Page_“Cover_Block”_‹_LearnWP_—_WordPress Edit_Page_“Cover_Block”_‹_LearnWP_—_WordPress

@richtabor
Copy link
Member

Thanks @kathrynwp — this is a duplicate of #50531 so I'll close this one. Please feel free to add additional feedback to that issue if needed. 🙇‍♂️

@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Color Contrast labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants