-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContrastChecker: Cover block overlay and text color incorrect #50531
Comments
I'm having flashbacks! This reminds me of a conversation we had around the unreliability of the contrast checker in the absence of solid colors, e.g., alpha It probably doesn't make sense in this scenario, but for reference we can turn off the contrast checker for blocks |
Yea, I'd like to avoid that here.
I don't think this is related to alpha, as the overlay is a div with the color and opacity applied. But it may be related to the Overlay color not being a standard color applied (like background and text is for all other blocks). |
I have also noticed that on the new beta 6.3 because there were changes on backgrounds and came to check if it was already reported... It stays the same. Even when I use black/White, no images (I understand with images can be more complicated). I don't know othe people, but I do use backgrounds a lot... |
Thanks for the ping @kathrynwp. @richtabor @annezazu in the interest of 6.3, I think we should disable the contrast checker with Setting |
I fear making calls here without involving accessibility. I've added the label for now to get their thoughts. Otherwise, what you shared seems sound to me. |
@alexstine @joedolson @afercia in case you have time. |
As-is, it’s giving a false positive for accessible color contrast - which is worse than having the checker at all. 😬 I think disabling it is the best temporary solution. |
This pretty clearly doesn't work right now. I'd agree that a warning that isn't trustable is worse than no warning at all. However, I think that getting this improved globally needs to be a high priority in 6.4. Will disabling the contrast checker only impact the cover block, but leave the innerblock supported? That contrast check still works when a background color is set on the innerblock, so I wouldn't want to lose that. |
See this discussion from year ago about how the contrast checker doesn't play well with the Cover block: #37731 (comment) It contributed to the motivation to create the enableContrastChecker flag Here's a PR to disable it for the Cover block: |
I've noticed that the ContrastChecker does not work well with the Cover block's Overlay and Text colors. Overall its very inconsistent, but I have noticed a few things in particular:
A. The notice shouldn't be fired in the default state (no text and overlay colors):
B. The ContrastChecker tends to five a false positive for accessible colors. i.e showing the notice when the color does have appropriate contrast. The checker should use to the Overlay fallback color (perhaps that should be set in the attribute, instead of CSS directly):
CleanShot.2023-05-10.at.16.37.03.mp4
C. Changing the Overlay color never fires the ContrastChecker.
The text was updated successfully, but these errors were encountered: