Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should disable toolbar buttons when open #50837

Closed
github-actions bot opened this issue May 22, 2023 · 1 comment · Fixed by #51365
Closed

[Flaky Test] should disable toolbar buttons when open #50837

github-actions bot opened this issue May 22, 2023 · 1 comment · Fixed by #51365
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented May 22, 2023

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should disable toolbar buttons when open

Test path

/test/e2e/specs/site-editor/style-book.spec.js

Errors

[2023-05-22T10:55:39.979Z] Test passed after 1 failed attempt on trunk.
[2023-05-22T15:17:39.619Z] Test passed after 1 failed attempt on fix/registered-fonts-for-site-editor-only.
[2023-05-22T20:29:46.838Z] Test passed after 1 failed attempt on try/search-button-only.
[2023-05-23T10:25:40.416Z] Test passed after 1 failed attempt on fix/accessibility-issues-navigation-block-experiment.
[2023-05-23T13:14:10.642Z] Test passed after 1 failed attempt on trunk.
[2023-05-23T14:56:53.073Z] Test passed after 1 failed attempt on add/test-coverage-for-comments-template-block-context.
[2023-05-24T10:56:45.699Z] Test passed after 1 failed attempt on add/back-to-top.
[2023-05-24T13:09:40.035Z] Test passed after 1 failed attempt on interactivity.
[2023-05-25T00:45:31.015Z] Test passed after 1 failed attempt on trunk.
[2023-05-25T05:30:18.442Z] Test passed after 1 failed attempt on update/file-spacing-support.
[2023-05-26T07:17:56.606Z] Test passed after 1 failed attempt on experiment/remove-interactivity-api-experimental-flag.
[2023-05-26T08:04:49.059Z] Test passed after 1 failed attempt on experiment/remove-interactivity-api-experimental-flag.
[2023-05-26T13:51:14.623Z] Test passed after 1 failed attempt on migrate-should-contain-label.
[2023-05-26T14:45:42.565Z] Test passed after 1 failed attempt on try/improve-link-ui-entry-type-matching.
[2023-05-29T17:25:00.879Z] Test passed after 1 failed attempt on update/link-control-move-text-control-outside-settings.
[2023-05-30T10:27:14.359Z] Test passed after 1 failed attempt on fix/navigation-block-aria-expanded-on-hover.
[2023-05-30T11:42:10.487Z] Test passed after 1 failed attempt on fix/customize-widgets-fixed-toolbar.
[2023-05-30T14:34:25.591Z] Test passed after 1 failed attempt on rnmobile/add-columns-test.
[2023-05-31T10:00:43.525Z] Test passed after 1 failed attempt on try/reduce-wp_array_get-use.
[2023-05-31T16:19:23.439Z] Test passed after 1 failed attempt on trunk.
[2023-05-31T17:31:54.889Z] Test passed after 1 failed attempt on fix/customize-widgets-fixed-toolbar.
[2023-06-01T10:12:20.657Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T11:51:50.759Z] Test passed after 1 failed attempt on try/additional-block-contents-component.
[2023-06-01T16:27:04.410Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-01T21:00:41.945Z] Test passed after 2 failed attempts on add/distraction-free-to-site-editor.
[2023-06-02T04:43:30.596Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T06:08:55.446Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T13:13:22.333Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-02T13:57:46.320Z] Test passed after 1 failed attempt on browse-mode-navigation-options.
[2023-06-02T16:00:21.002Z] Test passed after 1 failed attempt on try/font-library.
[2023-06-05T17:07:06.047Z] Test passed after 1 failed attempt on rename-syntax-to-double-hyphen-and-data-wp-interactive.
[2023-06-07T11:46:11.928Z] Test passed after 1 failed attempt on refactor/playwright-performance-tests.
[2023-06-08T02:05:36.448Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T09:45:24.312Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T14:35:31.993Z] Test passed after 1 failed attempt on add/categories-list-type.
[2023-06-08T20:40:49.164Z] Test passed after 1 failed attempt on refactor/remove-unnecesary-select-all.
[2023-06-08T20:41:00.198Z] Test passed after 1 failed attempt on tweak/linkcontrol-suggestions.
[2023-06-09T04:02:20.130Z] Test passed after 1 failed attempt on fix/remove-select-hack-from-getBlockEditingMode.
[2023-08-31T14:11:39.918Z] Test passed after 1 failed attempt on feat/async-block-loading.
Test timeout of 200000ms exceeded while running "beforeEach" hook.
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/style-book.spec.js:21:7
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label May 22, 2023
github-actions bot referenced this issue May 22, 2023
* Remove Add Submenu option

* Remove Link UI entirely
github-actions bot referenced this issue May 23, 2023
…ollow single responsibility principle (#50266)

* Introduce prepend_to_selector() method to avoid additional if checks and follow single responsibility principle.

* Don't call append_to_selector() when selector is likely empty.

* Remove parameter completely instead of deprecating.

* Correct doc block.
github-actions bot referenced this issue May 31, 2023
github-actions bot referenced this issue Jun 2, 2023
* Add static column number option

* Address feedback and fix Group placeholder

* Revert non-responsive option

* Try using grid layout in Post Template

* Update Post Template to use auto-fill columns

* Add block spacing to post template

* Show gap control by default

* Add unstable columns grid property

* Rename layout column attribute.

* Add a media query to reproduce current responsiveness

* Move layout controls to Post Template block

* Reduce max columns to 6.

* Remove unstable prefix

* fix cols breaking out of container

* Try adding deprecation

* Fix broken loop

* Update fixtures

* Code improvements

* Add some comments to the CSS.

* Add back deleted line

* Remove legacy attributes in deprecation

* Fix deprecation logic

* Update fixtures

* Fallback gap for classic themes

* fix spacing

* match old default value

* Update PHP test strings.

* Fix tag discrepancy in fixtures
github-actions bot referenced this issue Jun 2, 2023
…page's template (#50857)

* Add ability to prevent editing blocks using useBlockEditingMode()

* Make useBlockEditingMode use context

* Remove rootBlockEditingMode setting

* Fix private createRegistrySelector selectors

* Consolidate templateLock=contentOnly logic into getBlockEditingMode

* Hide disabled blocks from List View

* Hide disabled blocks from breadcrumbs

* Add doc comments

* Add unit tests

* Use @typedef to document mode param

* Restore packages/components/package.json from trunk

* Restore packages/block-library/src/post-title/edit.js from trunk

* Move BlockListBlockContext out of block.js so that it exists on mobile platforms

* Site Editor: Add ability to focus on editing a page's content vs the page's template

* Show page information in DocumentActions

* Implement Content panel

* Prevent block overlay on disabled blocks

* Fix Navigation block being selectable

* Show 'Page' in breadcrumbs when focused on editing page

* Update post title, post featured image, and post content blocks to say 'Page' instead of 'Post'

* toolbar title styling

* Remove removePostFromContentBlockLabels for now

* Fix being able to select text within disabled blocks

* Hide BlockAppender when block is disabled

* Fix comments block in non-post templates

* Update template card selector in E2E tests

* Fix 'Add submenu' button in Navigation block

* Remove unhelpful comments

* Remove more unnecessary comments

* Use constant for block types array

* Use BEMish selectors

* Be explicit that we're switching away from the page lock

* Update removePageFromBlockContext() test

* Fix post context from appearing in Edit Template preview

We have to set postId and postType to null for the preview and omit them
in the editor. No point having helper methods, therefore.

* Clear block selection when switching from template focus to page focus

* Prevent insertion into a disabled block

* Don't allow removing and moving children of disabled blocks

* Work around @wordpress/data bug by not using createRegistrySelector() for now

* Fix typo

* Fix select() mock

* Fix block-editor selector tests

* Revert block-editor changes

* Improve useDisableNonContentBlocks performance

* Fix performance tests

---------

Co-authored-by: Saxon Fletcher <[email protected]>
Co-authored-by: ramon <[email protected]>
github-actions bot referenced this issue Jun 8, 2023
…owns (#51154)

* DropdownMenu: read variant from context

* Toolbar: do not set `variant` prop on popover (rely on context system instead)

* Use named export for better storybook doc generation

* Provide context value in more toolbar components

* Hook Dropdown into context system, update DropdownMenu and CircularOptionPicker

* Remove toolbar variant popover prop where the context system can be used instead

* Add comment where the context system currently doesn't work

* Use placement prop instead of legacy "position" prop

* Add some temporary TODO comments

* Set toolbar variant for Dropdown in the context system

* Remove explicit variant prop from block alignment matrix control

* Toolbar: Only set context in the top-level component

* Remove `toolbar` variant from instances using `Dropdown`

* Simplify Dropdown implementation

* Tidy up types

* Remove toolbar variant storybook example for Popover

* CHANGELOG

* Complete renaming internal type

* Remove duplicate hardcoded classnames(already added by context connexct)
@github-actions github-actions bot reopened this Aug 31, 2023
@github-actions
Copy link
Author

github-actions bot commented Oct 1, 2023

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 1, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants