[Flaky Test] should warn of unsaved changes before loading reset revision #50419
Labels
[Type] Flaky Test
Auto-generated flaky test report issue
Comments
github-actions
bot
added
the
[Type] Flaky Test
github-actions bot
referenced
this issue
May 8, 2023
* initial commit. * Adding state for revisions Adding revisions global styles sidebar UI Adding revisions fill Adding revisions components and styles. Added e2e tests * Making selectors more consistent in e2e tests * This commit: - redesigns the revisions list to show a timeline view - changes the revisions endpoint response (and tests) to return a human friendly diff only. The frontend can format dates on the fly - Adds a slot to the edit side sidebar that can position a component at the bottom of the interface sidebar - updates e2e tests * This commit: - adds wordpress/date to package-lock.jdon - ensures that we correctly modify the user revisions to add unsaved and islatest flags * This commit: - extends the e2e test a little bit and adds a TODO to do it better - Adds ally labels to the color panel * This commit: - uses a clientside human-readable time diff method instead of the server side one. This is to make the response as close to the post revisions response as possible (for now) - makes the current timeline dot blue This commit: * This commit: - removes the specific author/user properties from the rest controller - grabs revision author information in the JS - shows a loading wheel while we grab revisions and user data * Label titles * Style adjustments Adding a reset to theme default item to the revisions list. Adding a dependencies to the `useMemo` so that it knows to update when the number of revisions change. This is so we can ensure we add the right metadata in the right order, e.g., `isLatest` Extracted hooks and components from screen revisions monster file * Adding tests for the useGetGlobalStylesRevisions hook * Extracting SCSS to external file Renaming date > meta in classname of DIV that wraps revision date and author meta Extra checks so that we don't render the meta block at all if there's no data * Reverting the reset theme default button and ensuring that revisions panel only display when there are more than two revisions. Updated tests accordingly. bumping gravatar size to 48 Updating other E2E tests after having added aria labels to the color controls Update e2e button spec after changes to button labels * This commit: - refactors useGlobalOutput by splitting out the build logic into a separate hook so that we can pass a custom config - uses wp.date.getSettings().formats.datetimeAbbreviated for formatted date in the revisions buttons - removes unnecessary role on the ordered list - updated copy - replacing modal component with the confirm dialog component - minor code optimizations - making the revisions store methods stable - updating tests - removing shouldShowClose button prop on the editor-canvas-container update e2e * Tweaked the revisions buttons copy, shifting the date and meta around. Updated tests --------- Co-authored-by: James Koster <[email protected]>
This was referenced May 8, 2023
github-actions bot
referenced
this issue
May 8, 2023
…viewports, or in template mode (#50361) * Update background color of post editor when viewing mobile or tablet viewports, or in template mode * Also update site editor color
github-actions bot
referenced
this issue
May 8, 2023
* Gallery: Fix inner block selection * Remove gallery focus hotfix from E2E tests
github-actions bot
referenced
this issue
May 8, 2023
* Try always showing the dimensions controls * Update defaults for Paragraph block
This was referenced May 8, 2023
github-actions bot
referenced
this issue
May 8, 2023
* Add setup api fetch test helper * Use setup api fetch helper in Image block test cases
This was referenced May 8, 2023
Merged
github-actions bot
referenced
this issue
May 8, 2023
* refactor: BlockList EmptyList uses Hooks Adopt modern React paradigms prior to refactoring the components composition. Completed to more closely mirror other code in the code base. * refactor: BlockList uses Hooks Adopt modern React paradigms prior to refactoring the components composition. Completed to more closely mirror other code in the code base. * refactor: BlockList higher-order components use Hooks Adopt modern React paradigms prior to refactoring the components composition. Completed to more closely mirror other code in the code base. Additionally, this removes the `withPreferredColorScheme` higher-order component as it appeared unused. * fix: BlockList footer interactivity `VirtualList` expects a React Component (e.g. `SomeComponent`), or a React element (e.g. `<SomeComponent` />) passed to the `ListFooterComponent` prop. Passing a function instead resulted in the block inserter never opening when tapping the block appender button within the footer; this appeared to be due to excessive re-renders resetting the `isOpen` state for the inserter. * fix: Rename Footer addBlockToEndOfPost callback prop The typo led to an undefined callback function. * fix: Reinstate missing prop used within store selector This prop was originally accessed via the `withSelect` higher-order component. When converting to Hooks, passing this prop was overlooked. * fix: Scope timer run by `waitForStoreResolvers` Running all timers could create testing failures in scenarios wheres where inner blocks were inserted, e.g. Social Icons. It is not known why, but scoping from "all" to "pending" timers resolved the following errors, without breaking any existing tests. Unknown origin: ``` Warning: You seem to have overlapping act() calls, this is not supported. Be sure to await previous act() calls before making a new one. ``` Originating from `waitForStoreResolvers`: ``` Ran 100000 timers, and there are still more! Assuming we've hit an infinite recursion and bailing out... ``` Originating from `packages/block-editor/src/components/block-list/test/index.native.js`: ``` thrown: "Exceeded timeout of 5000 ms for a test. ``` * test: BlockList renders footer appender * typo: Add code comment Added to align with sibling tests. * test: Expand empty BlockList appender tests
github-actions bot
referenced
this issue
May 8, 2023
* Add before / after container buttons * Update text with new expectations * Move `isTab` prevent default only when the component is actually handling the focus * CHANGELOG
github-actions bot
referenced
this issue
May 8, 2023
…9808) * Try innerblocks based details block * Cursor * Update save.js * Use "Details" as the fallback summary title * Use tagName in RichText for summary * Remove unset cursor in editor * Remove tagName summary Resolves the space bar issue * Remove border radius from supports * Move preventDefault to summary
github-actions bot
referenced
this issue
May 8, 2023
Removes mention of performance testing in the Gutenberg plugin release process documentation. Props to @priethor
github-actions bot
referenced
this issue
May 8, 2023
* Doc: Don't use markdown in the callout section * Add a missing code tag
This was referenced May 8, 2023
github-actions bot
referenced
this issue
May 8, 2023
Moves decision-making logic for iframed editor from the compat script-loader files into the Fonts API.
This was referenced May 8, 2023
Merged
github-actions bot
referenced
this issue
May 8, 2023
- Move to docker-compose down instead of docker-specific commands - Add timeout to resolve permissions issue
github-actions bot
referenced
this issue
May 8, 2023
* Removed Composer & PHPUnit Containers - Remove these containers because they don't work as expected, and are broken in many cases. It's also confusing to have a lot of random containers! - Add composer and phpunit to other containers so that they can still be used. (E.g. `wp-env run cli composer` instead of `wp-env run composer`) * Utilized `--env-cwd` Where Useful --------- Co-authored-by: Noah Allen <[email protected]>
This was referenced May 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.
Test title
should warn of unsaved changes before loading reset revision
Test path
/test/e2e/specs/site-editor/user-global-styles-revisions.spec.jsErrors
[2023-05-08T03:02:30.057Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T03:12:36.891Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T04:20:48.283Z]Test passed after 1 failed attempt ontry/visible-dimension-controls.[2023-05-08T05:00:32.310Z]Test passed after 1 failed attempt onadd/view-site-to-site-edit-nav.[2023-05-08T05:17:40.141Z]Test passed after 1 failed attempt ontry/visible-dimension-controls.[2023-05-08T05:21:52.673Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T05:37:17.225Z]Test passed after 1 failed attempt onupdate/file-block-text-formatting.[2023-05-08T05:40:36.400Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T06:09:12.397Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T06:45:28.911Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T07:29:22.723Z]Test passed after 1 failed attempt onfix/list-view-delete-and-focus.[2023-05-08T07:42:43.223Z]Test passed after 1 failed attempt onadd/elements-variations-custom-css.[2023-05-08T09:01:51.800Z]Test passed after 1 failed attempt onadd/store-open-close-api-commands.[2023-05-08T09:05:53.736Z]Test passed after 1 failed attempt onremove/quote-transform-from-group.[2023-05-08T09:16:20.994Z]Test passed after 1 failed attempt onupdate/file-block-interactivity-api.[2023-05-08T09:59:09.790Z]Test passed after 1 failed attempt onremove/quote-transform-from-group.[2023-05-08T10:05:25.617Z]Test passed after 1 failed attempt onupdate/document-title.[2023-05-08T10:25:35.423Z]Test passed after 1 failed attempt onadd/command-center-quick-link.[2023-05-08T10:54:39.153Z]Test passed after 1 failed attempt onuse/list-view-in-inspector.[2023-05-08T11:00:17.561Z]Test passed after 1 failed attempt onremove/offcanvaseditor-in-browse-mode.[2023-05-08T11:01:58.747Z]Test passed after 1 failed attempt onrevert/partially-49641.[2023-05-08T11:07:28.524Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T11:40:21.131Z]Test passed after 1 failed attempt onremove/offcanvaseditor-in-browse-mode.[2023-05-08T11:47:45.810Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T11:53:04.276Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T12:18:08.362Z]Test passed after 1 failed attempt ontry/aggressive-tinymce-deprecation.[2023-05-08T13:12:40.525Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T13:33:55.320Z]Test passed after 1 failed attempt onrefactor/block-list-uses-hooks.[2023-05-08T13:43:23.217Z]Test passed after 1 failed attempt ontry/site-edit-loading-experience-3.[2023-05-08T14:48:11.275Z]Test passed after 1 failed attempt onremove/offcanvaseditor-in-browse-mode.[2023-05-08T14:51:17.314Z]Test passed after 1 failed attempt onfix/list-view-color.[2023-05-08T14:56:22.165Z]Test passed after 1 failed attempt ondimensioncontrol/fix-code-example.[2023-05-08T15:02:23.470Z]Test passed after 1 failed attempt onuse/list-view-in-inspector.[2023-05-08T15:05:06.074Z]Test passed after 1 failed attempt onfix/navigable-container-focus-trap.[2023-05-08T15:10:59.062Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T15:37:09.900Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T16:06:35.896Z]Test passed after 1 failed attempt ondocs/use-atag-in-callout.[2023-05-08T16:38:34.475Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T16:40:36.197Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T16:43:11.319Z]Test passed after 1 failed attempt ondocs/use-atag-in-callout.[2023-05-08T16:52:43.440Z]Test passed after 1 failed attempt onfix/multiple-tooltips-site-editor.[2023-05-08T17:13:08.471Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T17:22:44.659Z]Test passed after 1 failed attempt onrnmobile/update/setup-media-picker.[2023-05-08T17:23:51.136Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T17:40:26.955Z]Test passed after 1 failed attempt onrnmobile/add/sandbox-test-id.[2023-05-08T17:53:23.767Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T18:27:46.744Z]Test passed after 1 failed attempt onrnmobile/add-embed-webview.[2023-05-08T18:47:08.705Z]Test passed after 1 failed attempt onfix/editor-iframe-margin-override.[2023-05-08T19:49:27.315Z]Test passed after 1 failed attempt ontry/move-printing-logic-to-wp_print_fonts.[2023-05-08T19:51:06.759Z]Test passed after 1 failed attempt oncheck-that-phpunit-runs.[2023-05-08T20:32:38.240Z]Test passed after 1 failed attempt onremove/select-parent-block-settings.[2023-05-08T20:43:42.639Z]Test passed after 1 failed attempt ontweak/insert-labels-block-settings.[2023-05-08T20:47:31.913Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T21:28:15.866Z]Test passed after 1 failed attempt onfix-wp-env-destroy.[2023-05-08T21:40:22.723Z]Test passed after 1 failed attempt onperf/reduce-inner-blocks-tree-depth.[2023-05-08T21:49:44.563Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T21:56:09.601Z]Test passed after 1 failed attempt onrnmobile/add-embed-webview.[2023-05-08T21:58:00.566Z]Test passed after 1 failed attempt oncheck-that-phpunit-runs.[2023-05-08T22:14:18.810Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T22:36:03.967Z]Test passed after 1 failed attempt ontrunk.[2023-05-08T22:58:49.341Z]Test passed after 1 failed attempt onperf/reduce-inner-blocks-tree-depth.[2023-05-08T23:27:18.202Z]Test passed after 1 failed attempt onfix/editor-iframe-margin-override.[2023-05-09T00:05:49.621Z]Test passed after 1 failed attempt onupdate/block-edit-menu-item-order.[2023-05-09T01:08:15.878Z]Test passed after 1 failed attempt onrnmobile/add-embed-webview.[2023-05-09T01:51:51.028Z]Test passed after 1 failed attempt onrnmobile/add-embed-webview.[2023-05-09T02:01:03.150Z]Test passed after 1 failed attempt onbehaviors-ui.[2023-05-09T02:39:40.919Z]Test passed after 1 failed attempt onrnmobile/add-embed-webview.[2023-05-09T04:24:49.772Z]Test passed after 1 failed attempt onrnmobile/add-embed-webview.[2023-05-09T04:58:57.780Z]Test passed after 1 failed attempt onfix/reset-of-spacing-sizes-control.The text was updated successfully, but these errors were encountered: