Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for wp.data.subscribe do not reflect changes in #5003 #5032

Closed
Shelob9 opened this issue Feb 13, 2018 · 3 comments
Closed

Docs for wp.data.subscribe do not reflect changes in #5003 #5032

Shelob9 opened this issue Feb 13, 2018 · 3 comments
Labels
[Type] Question Questions about the design or development of the editor.

Comments

@Shelob9
Copy link
Contributor

Shelob9 commented Feb 13, 2018

In these doc for wp.data.subscribe, and example of subscribing to changes in the post title is given:
https://github.com/WordPress/gutenberg/tree/master/data#wpdatasubscribe-listener-function-

This example is wrong, because of changes in #5003 I'll put in a PR.

Shelob9 added a commit to Shelob9/gutenberg that referenced this issue Feb 13, 2018
Shelob9 added a commit to Shelob9/gutenberg that referenced this issue Feb 13, 2018
@youknowriad
Copy link
Contributor

Thanks for opening the issue @Shelob9 but what's wrong in the docs? The selector being used is just an example. These docs are meant to explain the data module and not the core/editor module's selectors.

@youknowriad youknowriad added the [Type] Question Questions about the design or development of the editor. label Feb 14, 2018
@Shelob9
Copy link
Contributor Author

Shelob9 commented Feb 15, 2018

The names of the selectors changes in #5003 I was updating them to match. But they have changed again since then.

@danielbachhuber
Copy link
Member

Looks like this is no longer valid. Feel free to re-open if this isn't the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

3 participants