Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block does not show Media Settings (fixed / repeated background) when the featured image is used in Site Editor #46155

Open
kavyagokul opened this issue Nov 29, 2022 · 3 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.

Comments

@kavyagokul
Copy link

Description

When we use a Cover block with the featured image instead of the Post Featured Image block in Site Editor > Single template, the Cover block does not show the Media settings so the fixed background effect cannot be used.

Step-by-step reproduction instructions

  1. Insert a Cover Block and set Use the featured image
  2. There are no Media Settings.
  3. When I add an actual Media, they show up.

Screenshots, screen recording, code snippet

204130168-91793c89-e81e-46b2-a4ac-e7614e208fb0.mp4

Environment info

WordPress 6.1.1
Gutenberg 14.6.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Navigation Affects the Navigation Block [Block] Social Affects the Social Block - used to display Social Media accounts [Block] Post Featured Image Affects the Post Featured Image Block [Feature] Colors Color management and removed [Block] Navigation Affects the Navigation Block [Block] Social Affects the Social Block - used to display Social Media accounts [Block] Post Featured Image Affects the Post Featured Image Block [Feature] Colors Color management labels Dec 4, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 28, 2023
@akasunil
Copy link
Member

Im not sure if there was issue as i don't see featured image uploaded in provided video in description. However, Its works fine in latest version of Gutenberg. @t-hamano I think we can close this issue.
CleanShot 2024-04-17 at 17 16 27@2x

@t-hamano
Copy link
Contributor

This problem should be reproducible with the latest Gutenberg. The important thing is to insert this block outside the post context. For example, if you insert this block inside a Query Loop block in the Post Editor or Archive template, it will identify which post it is, so the actual image will be displayed, and the media settings will be displayed.

However, in the case of a single template, the editor is not dependent on a specific post, so the placeholder is always displayed. As a result, media settings are not displayed.

It's hard to say whether this is a bug or an improvement, but I think it's best to leave this issue open.

cover-block-single-template

@annezazu
Copy link
Contributor

Confirming this is still the case when using the cover block in a single template and setting it to use a featured image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants